From fc0119d09ebb1dad90a23086dd8c90b354e3cc82 Mon Sep 17 00:00:00 2001
From: Colin <colin.diesh@gmail.com>
Date: Thu, 29 Sep 2022 08:14:26 -0600
Subject: [PATCH] Session wide about detail formatter

---
 packages/core/ui/AboutDialog.tsx              | 14 +++++++--
 products/jbrowse-web/src/jbrowseModel.ts      | 31 +++++++++++++++++++
 .../jbrowse-web/src/sessionModelFactory.ts    |  6 ++--
 test_data/volvox/config_main_thread.json      |  4 +++
 4 files changed, 50 insertions(+), 5 deletions(-)

diff --git a/packages/core/ui/AboutDialog.tsx b/packages/core/ui/AboutDialog.tsx
index b125c04ed2..ba69fe9700 100644
--- a/packages/core/ui/AboutDialog.tsx
+++ b/packages/core/ui/AboutDialog.tsx
@@ -10,7 +10,11 @@ import {
 } from '@mui/material'
 import CloseIcon from '@mui/icons-material/Close'
 import { makeStyles } from 'tss-react/mui'
-import { readConfObject, AnyConfigurationModel } from '../configuration'
+import {
+  getConf,
+  readConfObject,
+  AnyConfigurationModel,
+} from '../configuration'
 import { getSession } from '../util'
 import { getTrackName } from '../util/tracks'
 import { BaseCard, Attributes } from '../BaseFeatureWidget/BaseFeatureDetail'
@@ -43,10 +47,14 @@ export default function AboutDialog({
   const session = getSession(config)
   const { rpcManager } = session
   const conf = readConfObject(config)
-  const hideUris = readConfObject(config, ['formatAbout', 'hideUris'])
+  const hideUris =
+    readConfObject(config, ['formatAbout', 'hideUris']) ||
+    getConf(session, ['formatAbout', 'hideUris'])
+
   const confPost = {
     ...conf,
     ...readConfObject(config, ['formatAbout', 'conf'], { conf }),
+    ...getConf(session, ['formatAbout', 'conf'], { conf }),
   }
 
   useEffect(() => {
@@ -102,7 +110,7 @@ export default function AboutDialog({
       </DialogTitle>
       <DialogContent className={classes.content}>
         <BaseCard title="Configuration">
-          {hideUris ? (
+          {!hideUris ? (
             <Button
               variant="contained"
               style={{ float: 'right' }}
diff --git a/products/jbrowse-web/src/jbrowseModel.ts b/products/jbrowse-web/src/jbrowseModel.ts
index da80e9afc5..f3a681c756 100644
--- a/products/jbrowse-web/src/jbrowseModel.ts
+++ b/products/jbrowse-web/src/jbrowseModel.ts
@@ -62,6 +62,37 @@ export default function JBrowseWeb(
             defaultValue: ['mRNA', 'transcript'],
           },
         }),
+        formatDetails: ConfigurationSchema('FormatDetails', {
+          feature: {
+            type: 'frozen',
+            description: 'adds extra fields to the feature details',
+            defaultValue: {},
+            contextVariable: ['feature'],
+          },
+          subfeatures: {
+            type: 'frozen',
+            description: 'adds extra fields to the subfeatures of a feature',
+            defaultValue: {},
+            contextVariable: ['feature'],
+          },
+          depth: {
+            type: 'number',
+            defaultValue: 2,
+            description: 'depth to iterate on subfeatures',
+          },
+        }),
+        formatAbout: ConfigurationSchema('FormatAbout', {
+          conf: {
+            type: 'frozen',
+            description: 'formats configuration object in about dialog',
+            defaultValue: {},
+            contextVariable: ['conf'],
+          },
+          hideUris: {
+            type: 'boolean',
+            defaultValue: false,
+          },
+        }),
         disableAnalytics: {
           type: 'boolean',
           defaultValue: false,
diff --git a/products/jbrowse-web/src/sessionModelFactory.ts b/products/jbrowse-web/src/sessionModelFactory.ts
index b3494469d3..f045fcc596 100644
--- a/products/jbrowse-web/src/sessionModelFactory.ts
+++ b/products/jbrowse-web/src/sessionModelFactory.ts
@@ -1,12 +1,13 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
 import { lazy } from 'react'
 import clone from 'clone'
-import { AnyConfigurationModel } from '@jbrowse/core/configuration/configurationSchema'
+import shortid from 'shortid'
 import { PluginDefinition } from '@jbrowse/core/PluginLoader'
 import {
   readConfObject,
   getConf,
   isConfigurationModel,
+  AnyConfigurationModel,
 } from '@jbrowse/core/configuration'
 import {
   Region,
@@ -38,11 +39,12 @@ import {
 import PluginManager from '@jbrowse/core/PluginManager'
 import TextSearchManager from '@jbrowse/core/TextSearch/TextSearchManager'
 import RpcManager from '@jbrowse/core/rpc/RpcManager'
+
+// icons
 import SettingsIcon from '@mui/icons-material/Settings'
 import CopyIcon from '@mui/icons-material/FileCopy'
 import DeleteIcon from '@mui/icons-material/Delete'
 import InfoIcon from '@mui/icons-material/Info'
-import shortid from 'shortid'
 
 const AboutDialog = lazy(() => import('@jbrowse/core/ui/AboutDialog'))
 
diff --git a/test_data/volvox/config_main_thread.json b/test_data/volvox/config_main_thread.json
index 7411bf12ef..3ec9256e81 100644
--- a/test_data/volvox/config_main_thread.json
+++ b/test_data/volvox/config_main_thread.json
@@ -2,6 +2,10 @@
   "configuration": {
     "rpc": {
       "defaultDriver": "MainThreadRpcDriver"
+    },
+    "formatAbout": {
+      "hideUris": true,
+      "conf": "jexl:{extraField:'important data'}"
     }
   },
   "assemblies": [