Fix allRefNames on assembly #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
reviewed
Nov 3, 2020
| aliases = aliases.concat(aliasList) | ||
| const aliases: string[] = [] | ||
| self.refNameAliases.forEach((_canonicalName, alias) => { | ||
| if (this.refNames && !this.refNames.includes(alias)) { |
There was a problem hiding this comment.
refNameAliases contains the canonical refNames so should be able to return keys of refNameAliases only
|
what was the motivation for this? what problem was cropping up? |
Codecov Report
@@ Coverage Diff @@
## master #1390 +/- ##
==========================================
- Coverage 59.38% 59.34% -0.04%
==========================================
Files 418 418
Lines 18683 18684 +1
Branches 4404 4405 +1
==========================================
- Hits 11094 11088 -6
- Misses 7294 7301 +7
Partials 295 295
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores previous functionality to return a list of all refNames and aliases.