Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new spectron tests #1028

Merged
merged 53 commits into from May 2, 2018

Conversation

Projects
None yet
2 participants
@rbuels
Copy link
Collaborator

rbuels commented Mar 23, 2018

No description provided.

@cmdcolin cmdcolin force-pushed the add_new_spectron_test branch 2 times, most recently from 42bdbc9 to ab767d1 Mar 24, 2018

@rbuels

This comment has been minimized.

Copy link
Collaborator Author

rbuels commented Mar 27, 2018

before merging this, could you add a couple basic tests, maybe opening a session and confirming that it's showing the tracks or something?

@rbuels

This comment has been minimized.

Copy link
Collaborator Author

rbuels commented Mar 27, 2018

but this is fricken sweet

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Apr 2, 2018

Getting a little closer to testing the functionality of desktop app

@cmdcolin cmdcolin force-pushed the add_new_spectron_test branch 2 times, most recently from 4c5cc0c to e9c8b55 Apr 2, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Apr 6, 2018

I think the code on this branch has been robustified and the makefile is updated to build releases

I think since it just globs zip files the built versions would be uploaded to github too

There was a cool "Open plugin" function in the old version but it is deleted with the webpack code additions :)

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Apr 6, 2018

Might have to use travis OSX image to build windows version electron-userland/electron-builder#1751

edit: instead of OSX looks like upgrading wine package worked. required setting sudo on travis at least for ease of installation though

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Apr 6, 2018

I think this should pass now, if there's interest can try to test deploy to github

@cmdcolin cmdcolin force-pushed the add_new_spectron_test branch 2 times, most recently from 524cb30 to 43b4ec8 Apr 6, 2018

@rbuels rbuels added this to the 1.14.1 milestone Apr 17, 2018

@cmdcolin cmdcolin force-pushed the add_new_spectron_test branch from a158ea0 to 2df4cf6 Apr 23, 2018

cmdcolin added some commits Apr 23, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Apr 23, 2018

I added a new test that opens a saved session and turns on a track

This also was backed by some changes including

  • Using a mock system dialog for the test in electron
  • Adding command line args to the electron program so you can pass electronData (directory for sessions.json and friends) which helps isolate tests, but then also lets you pass other args such as --data --loc --tracks etc that get mapped to normal the URL params
  • Fixing welcome page CSS with jbrowse class
  • Retabbing some files
  • Fixing a bug where FASTA file loader crashed without message when file not found

@rbuels rbuels merged commit 3ef66f9 into dev May 2, 2018

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.