New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and add gff getRegionFeatureDensity calculations #1039

Merged
merged 3 commits into from Apr 20, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Contributor

cmdcolin commented Apr 18, 2018

This attempts to make the autogenerated gff3tabix histogram a little more accurate by incrementing all histogram bins covered by features from state to end (previously it only incremented first bin)

This also adds getRegionFeatureDensities to the regular GFF3 adapter

I also removed one of the sample tracks because it seemed confusing that it used a different feature density bigwig that didn't accurately reflect underlying data

Screenshot

screenshot-localhost-2018 04 18-19-09-16 1

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Apr 18, 2018

Would fix #913

@rbuels rbuels merged commit b0422cc into dev Apr 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@rbuels

This comment has been minimized.

Collaborator

rbuels commented Apr 20, 2018

@cmdcolin could you add this to the release notes?

@rbuels rbuels added this to the 1.14.1 milestone Apr 20, 2018

@cmdcolin cmdcolin deleted the fix_gff3tabix_histo branch Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment