Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Support both ID and name indexing in GFF3Tabix #1069
I know this sounds a little pedantic but it would actually be ideal to enable arbitrary fields to be indexed. The --nameAttributes of flatfile-to-json (not generate-names.pl) allows you to choose which fields to be indexed by generate-names.pl
It would be cool to get that full functionality available
Well, some GFF3 files have just UUIDs or serial numbers for
The biggest downside I can see to merging this would be bloating the name index with meaningless IDs, for people with meaningless ones. That's probably not a huge concern though, the name index is pretty scalable.
@cmdcolin can you see any other reason not to merge this? If not, do you think you could make a new pull request out of this that also updates the Perl tests to pass, and adds a note in release-notes, close this pull request when you do that, and reference this in the new pull request ?