New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for embedded minified builds #1239

Merged
merged 2 commits into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@garrettjstevens
Copy link
Contributor

garrettjstevens commented Oct 23, 2018

Add standalone.js to the list of files that glob-loader.js looks for. Also includes a fix so JBrowse doesn't complain about not being able to find empty.gif when JBROWSE_PUBLIC_PATH is overridden.

Resolves #1238

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Oct 23, 2018

Nice catch! I'll give it a test but that seems right

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Oct 24, 2018

I tested this out with the JBROWSE_PUBLIC_PATH rebuild and it seems to work great.

Is it possible to get the standalone working from an NPM installed @gmod/jbrowse? I am just worried the npm installed @gmod/jbrowse would not work due to things related to JBROWSE_PUBLIC_PATH or is that not true? Also the standalone/index.html example that you provided in #1238 is really awesome I'd like that to be in the docs or similar :)

@rbuels

This comment has been minimized.

Copy link
Collaborator

rbuels commented Oct 24, 2018

@cmdcolin the npm-installed jbrowse would only work with standalone.js if the public path is the default dist/. Most of the time, people are going to need to use a git clone.

If we really want to improve support for installing JBrowse 1 from npm, though, we could support a scenario in which people pull our webpack.config in as a node module into their own webpack.config. That would probably be the right way to do it.

@rbuels rbuels added this to the 1.15.5 milestone Oct 24, 2018

@rbuels rbuels merged commit f2125c2 into dev Oct 24, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Oct 24, 2018

@garrettjstevens garrettjstevens deleted the embedded_build branch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment