Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CRAM regularizing failing #1367

Merged
merged 5 commits into from May 21, 2019

Conversation

Projects
None yet
2 participants
@cmdcolin
Copy link
Contributor

commented May 21, 2019

Currently there are examples of CRAM name regularizing failing due to interaction with the sequence stores

  • We have a CRAM using nomenclature MT
  • The FASTA is using nomenclature MT
  • The system internal to CRAM uses name regularization and makes this chrm
  • Then it requests chrm from the seqFetch callback, at which point it fails

When it gets to the seq store, there is differing behavior depending on seqStore

  1. The IndexedFasta does not use the query name, it uses this.refSeq.name, so it actually works
  2. The SequenceChunks does something called compareReferenceSequence(this.refSeq.name, query.ref) and if this is 0, then it queries with this.refSeq.name. there was a bug with this that resulted in MT getting double regularized though so it went from MT->chrm->chr
  3. The TwoBit only uses query name

The fix here is to avoid the regularization failure and make the behavior across sequence stores more consistent

@cmdcolin cmdcolin changed the base branch from master to dev May 21, 2019

@cmdcolin cmdcolin force-pushed the regularize_properly branch from 8ceefc1 to 7fb2ccc May 21, 2019

@rbuels

rbuels approved these changes May 21, 2019

Copy link
Collaborator

left a comment

dude good catch. just the one question

Show resolved Hide resolved src/JBrowse/Browser.js Outdated

@cmdcolin cmdcolin merged commit 3ddd394 into dev May 21, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@cmdcolin cmdcolin deleted the regularize_properly branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.