fix bug on --refs option #497

Merged
merged 2 commits into from Jul 31, 2014

Conversation

Projects
None yet
2 participants
@andronekomimi
Contributor

andronekomimi commented Jul 31, 2014

Hello,

While trying to use the --refs parameters with --fasta options, I've got fatal errors (on the $refs hash and the uninitialized current_chunk variable).
The following code had fixed the bug.
Could you please apply this path.

Regards!

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Jul 31, 2014

Contributor

Good catch! Thank you very much for the patch too. We will get this incorporated. I also found it can be fixed by:

-        $refs = { map $_ => 1, split /\s*,\s*/, $refs };
+        $refs = { map { $_ => 1 } split /\s*,\s*/, $refs };

But maybe we will stick with your change after all

Contributor

cmdcolin commented Jul 31, 2014

Good catch! Thank you very much for the patch too. We will get this incorporated. I also found it can be fixed by:

-        $refs = { map $_ => 1, split /\s*,\s*/, $refs };
+        $refs = { map { $_ => 1 } split /\s*,\s*/, $refs };

But maybe we will stick with your change after all

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Jul 31, 2014

Contributor

Do you want credit on the release notes? We typically credit authors by name

Contributor

cmdcolin commented Jul 31, 2014

Do you want credit on the release notes? We typically credit authors by name

@andronekomimi

This comment has been minimized.

Show comment
Hide comment
@andronekomimi

andronekomimi Jul 31, 2014

Contributor

Hi!

That's would incredibly cool ;-)
Thanx a lot

Audrey

2014-07-31 19:13 GMT+02:00 Colin notifications@github.com:

Do you want credit on the release notes? We typically credit authors by
name

Reply to this email directly or view it on GitHub
#497 (comment).

Parce que j'aime le Code qu'il soit Génétique ou Informatique

Contributor

andronekomimi commented Jul 31, 2014

Hi!

That's would incredibly cool ;-)
Thanx a lot

Audrey

2014-07-31 19:13 GMT+02:00 Colin notifications@github.com:

Do you want credit on the release notes? We typically credit authors by
name

Reply to this email directly or view it on GitHub
#497 (comment).

Parce que j'aime le Code qu'il soit Génétique ou Informatique

@cmdcolin cmdcolin merged commit 5c1b24a into GMOD:master Jul 31, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment