Wiggle tracks now shows pixel values of 0 on mouse over #503

Merged
merged 1 commit into from Feb 6, 2015

Conversation

Projects
None yet
2 participants
@hotdogee
Contributor

hotdogee commented Aug 19, 2014

This fixes the problem when using binary 0/1 tracks, zeros were not being displayed.

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Aug 19, 2014

Contributor

Thanks (all your patches are very well done!!!)

Just an aside, I guess the issue is that when score['score'] is 0 this fails because it is equivalent to false. I'd say we merge this

Also if it's unclear to others, the bug you mention can be noticed by trying to hover over the wiggle at the very start of the track here http://jbrowse.org/code/JBrowse-1.11.4/?loc=ctgA%3A1..52&tracks=volvox_sine_xyplot&data=sample_data%2Fjson%2Fvolvox&highlight=&tracklist=1&nav=1&overview=1

Contributor

cmdcolin commented Aug 19, 2014

Thanks (all your patches are very well done!!!)

Just an aside, I guess the issue is that when score['score'] is 0 this fails because it is equivalent to false. I'd say we merge this

Also if it's unclear to others, the bug you mention can be noticed by trying to hover over the wiggle at the very start of the track here http://jbrowse.org/code/JBrowse-1.11.4/?loc=ctgA%3A1..52&tracks=volvox_sine_xyplot&data=sample_data%2Fjson%2Fvolvox&highlight=&tracklist=1&nav=1&overview=1

cmdcolin added a commit that referenced this pull request Feb 6, 2015

Merge pull request #503 from hotdogee/wiggle-show-zero
Wiggle tracks now shows pixel values of 0 on mouse over

@cmdcolin cmdcolin merged commit 149d86c into GMOD:master Feb 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment