Electron app #647

Merged
merged 95 commits into from Dec 2, 2015

Conversation

Projects
None yet
4 participants
@cmdcolin
Contributor

cmdcolin commented Nov 2, 2015

Basic ideas:

  • Uses the current codebase without much modification
  • Has a Makefile build step for packaging with the minimized codebase (which produces exe's for win,osx,linux)
  • Adds an "Open data directory" menu option to the electron app
  • Ability to open indexed FASTA (and retains un-indexed FASTA mode, but alerts if over 100MB)

Updated 12/01

@cmdcolin cmdcolin changed the title from [Work in progress] Electron app to Electron app Nov 2, 2015

@enuggetry

This comment has been minimized.

Show comment
Hide comment
@enuggetry

enuggetry Nov 2, 2015

Contributor

Very nice addition to jbrowse! Ready to fly, out of the box.

On Mon, Nov 2, 2015 at 12:11 PM, Colin Diesh notifications@github.com
wrote:

This is still a work in progress but the basic idea is there

Basic ideas:

  • Uses the current codebase without much modification
  • Has a Makefile build step for packaging with the minimized codebase
    (which produces exe's for win,osx,linux)
  • Adds an "Open data directory" menu option. This doesn't work yet but
    it is similar to the idea of "Open FASTA file" in principle to reset the
    browser with the new data.

You can get a sample exe here

https://drive.google.com/folderview?id=0BxkRH5zBEJ33NG1WSmhKU1Y4clE&usp=sharing

You can view, comment on, or merge this pull request online at:

#647
Commit Summary

  • Remove some symlinks
  • Update index for Electron
  • Update README.md
  • Add Electron browser and config
  • Check for electron
  • Update docs
  • Add release-electron-darwin command
  • Rename to JBrowseDesktop
  • Add loading text
  • Remove the target blank link
  • Check for electron in 404 error
  • Update README.md
  • Check for process global
  • Conditionally delete require
  • Fasta file retab
  • Check for window.process
  • Update Browser code with retabs and DataDirectoryDialog
  • Use window.process to check for electron
  • Remove DataDirectoryDialog
  • Use modifier to select directories on the filesystem
  • Add a build all Makefile step

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#647.

Contributor

enuggetry commented Nov 2, 2015

Very nice addition to jbrowse! Ready to fly, out of the box.

On Mon, Nov 2, 2015 at 12:11 PM, Colin Diesh notifications@github.com
wrote:

This is still a work in progress but the basic idea is there

Basic ideas:

  • Uses the current codebase without much modification
  • Has a Makefile build step for packaging with the minimized codebase
    (which produces exe's for win,osx,linux)
  • Adds an "Open data directory" menu option. This doesn't work yet but
    it is similar to the idea of "Open FASTA file" in principle to reset the
    browser with the new data.

You can get a sample exe here

https://drive.google.com/folderview?id=0BxkRH5zBEJ33NG1WSmhKU1Y4clE&usp=sharing

You can view, comment on, or merge this pull request online at:

#647
Commit Summary

  • Remove some symlinks
  • Update index for Electron
  • Update README.md
  • Add Electron browser and config
  • Check for electron
  • Update docs
  • Add release-electron-darwin command
  • Rename to JBrowseDesktop
  • Add loading text
  • Remove the target blank link
  • Check for electron in 404 error
  • Update README.md
  • Check for process global
  • Conditionally delete require
  • Fasta file retab
  • Check for window.process
  • Update Browser code with retabs and DataDirectoryDialog
  • Use window.process to check for electron
  • Remove DataDirectoryDialog
  • Use modifier to select directories on the filesystem
  • Add a build all Makefile step

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#647.

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Nov 3, 2015

Contributor

Added some updates

(a) Opening a data directory works now. Also, instead of using the browser teardown code, it simply refreshes the page with ?data=
(b) Opening an indexed fasta file works too. It creates a new trackList.json in the same folder as that indexed fasta, and then, similarly, refreshes the page with ?data= (since writing the trackList.json there essentially initializes the data directory)

Put together, I think these two features makes the electron app quite usable.
Here's a new folder with links https://drive.google.com/folderview?id=0BxkRH5zBEJ33cFlsRlUtNXBTUHM&usp=sharing

Contributor

cmdcolin commented Nov 3, 2015

Added some updates

(a) Opening a data directory works now. Also, instead of using the browser teardown code, it simply refreshes the page with ?data=
(b) Opening an indexed fasta file works too. It creates a new trackList.json in the same folder as that indexed fasta, and then, similarly, refreshes the page with ?data= (since writing the trackList.json there essentially initializes the data directory)

Put together, I think these two features makes the electron app quite usable.
Here's a new folder with links https://drive.google.com/folderview?id=0BxkRH5zBEJ33cFlsRlUtNXBTUHM&usp=sharing

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Nov 3, 2015

Contributor

Updated the downloads with a small fix. Currently expects tracks.conf file to exist :)

Contributor

cmdcolin commented Nov 3, 2015

Updated the downloads with a small fix. Currently expects tracks.conf file to exist :)

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Nov 25, 2015

Contributor

Updated downloads

This works for opening an indexed FASTA file in both the webapp and electron-app

https://drive.google.com/folderview?id=0BxkRH5zBEJ33dDRHWWd0eFBkQkU&usp=sharing

Contributor

cmdcolin commented Nov 25, 2015

Updated downloads

This works for opening an indexed FASTA file in both the webapp and electron-app

https://drive.google.com/folderview?id=0BxkRH5zBEJ33dDRHWWd0eFBkQkU&usp=sharing

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Dec 1, 2015

Contributor

Alrighty I restored the ability to load the unindexed FASTA files now

It gives an "Are you sure" if it's over 100MB, and recommends using the FAI file :)

Contributor

cmdcolin commented Dec 1, 2015

Alrighty I restored the ability to load the unindexed FASTA files now

It gives an "Are you sure" if it's over 100MB, and recommends using the FAI file :)

@cmdcolin cmdcolin removed the in progress label Dec 1, 2015

@enuggetry

This comment has been minimized.

Show comment
Hide comment
@enuggetry

enuggetry Dec 1, 2015

Contributor

Nice. Thanks.
On Dec 1, 2015 10:21 AM, "Colin Diesh" notifications@github.com wrote:

Alrighty I restored the ability to load the unindexed FASTA files now

It gives an "Are you sure" if it's over 100MB, and recommends using the
FAI file :)


Reply to this email directly or view it on GitHub
#647 (comment).

Contributor

enuggetry commented Dec 1, 2015

Nice. Thanks.
On Dec 1, 2015 10:21 AM, "Colin Diesh" notifications@github.com wrote:

Alrighty I restored the ability to load the unindexed FASTA files now

It gives an "Are you sure" if it's over 100MB, and recommends using the
FAI file :)


Reply to this email directly or view it on GitHub
#647 (comment).

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Dec 2, 2015

Contributor

I was gonna go ahead and merge this! Lemme know if any objections

Contributor

cmdcolin commented Dec 2, 2015

I was gonna go ahead and merge this! Lemme know if any objections

@enuggetry

This comment has been minimized.

Show comment
Hide comment
@enuggetry

enuggetry Dec 2, 2015

Contributor

If you feel good about it, pls do.
On Dec 2, 2015 12:37 PM, "Colin Diesh" notifications@github.com wrote:

I was gonna go ahead and merge this! Lemme know if any objections


Reply to this email directly or view it on GitHub
#647 (comment).

Contributor

enuggetry commented Dec 2, 2015

If you feel good about it, pls do.
On Dec 2, 2015 12:37 PM, "Colin Diesh" notifications@github.com wrote:

I was gonna go ahead and merge this! Lemme know if any objections


Reply to this email directly or view it on GitHub
#647 (comment).

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Dec 2, 2015

Contributor

Alright!

Contributor

cmdcolin commented Dec 2, 2015

Alright!

cmdcolin added a commit that referenced this pull request Dec 2, 2015

@cmdcolin cmdcolin merged commit 3cabbdf into master Dec 2, 2015

1 check was pending

continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@cmdcolin cmdcolin deleted the electron_app branch Dec 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment