XYPlot - noFill option to give scatter like plots #741

Merged
merged 2 commits into from Mar 22, 2017

Conversation

Projects
None yet
4 participants
@keiranmraine
Contributor

keiranmraine commented May 13, 2016

As discussed in #740

Adds 'noFill' option which results in just the top (or bottom) end of bar being rendered for XYplot. Image shows 2 tracks, positive and negative values respectively (a mirror image of each other).

screen shot 2016-05-13 at 22 21 09

Just need to add "noFill": true to track config, e.g. a base loaded BigWig track would now be:

{
  "maxExportSpan": 500000,
  "autoscale": "local",
  "logScaleOption": true,
  "style": {
    "pos_color": "blue",
    "neg_color": "red",
    "origin_color": "#888",
    "variance_band_color": "rgba(0,0,0,0.3)",
    "height": 100
  },
  "label": "BigWig_1kb_1",
  "key": "BigWig 1kb",
  "type": "JBrowse/View/Track/Wiggle/XYPlot",
  "category": "Local tracks",
  "metadata": {},
  "noFill": true
}
@nathandunn

This comment has been minimized.

Show comment
Hide comment
@nathandunn

nathandunn May 13, 2016

Contributor

👍 Is there a place to add doc to this @enuggetry ?

Contributor

nathandunn commented May 13, 2016

👍 Is there a place to add doc to this @enuggetry ?

@keiranmraine

This comment has been minimized.

Show comment
Hide comment
@keiranmraine

keiranmraine Jun 7, 2016

Contributor

Could a menu option be added to toggle this? I can see the toggle for LogScale in WiggleBase, would I replicate and extend this function in Wiggle/XYPlot or is there a better way to add the function?

Contributor

keiranmraine commented Jun 7, 2016

Could a menu option be added to toggle this? I can see the toggle for LogScale in WiggleBase, would I replicate and extend this function in Wiggle/XYPlot or is there a better way to add the function?

@enuggetry

This comment has been minimized.

Show comment
Hide comment
@enuggetry

enuggetry Jun 7, 2016

Contributor

yes. will put it in the next release.
I agree, a menu or toolbar toggle would be nice.

Contributor

enuggetry commented Jun 7, 2016

yes. will put it in the next release.
I agree, a menu or toolbar toggle would be nice.

@enuggetry

This comment has been minimized.

Show comment
Hide comment
@enuggetry

enuggetry Jun 7, 2016

Contributor

Thanks @keiranmraine !

Contributor

enuggetry commented Jun 7, 2016

Thanks @keiranmraine !

@keiranmraine

This comment has been minimized.

Show comment
Hide comment
@keiranmraine

keiranmraine Jun 7, 2016

Contributor

Menu option added as agreed.

screen shot 2016-06-07 at 19 53 16

screen shot 2016-06-07 at 19 53 24

Contributor

keiranmraine commented Jun 7, 2016

Menu option added as agreed.

screen shot 2016-06-07 at 19 53 16

screen shot 2016-06-07 at 19 53 24

@enuggetry

This comment has been minimized.

Show comment
Hide comment
@enuggetry

enuggetry Jun 7, 2016

Contributor

Nice! thanks!

Contributor

enuggetry commented Jun 7, 2016

Nice! thanks!

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Mar 22, 2017

Contributor

Should be fine to merge I think

Just a random note but it is actually in general a little tricky to turn this into a generic line plot instead of just dots, although if there is interest that could maybe be added later too

Contributor

cmdcolin commented Mar 22, 2017

Should be fine to merge I think

Just a random note but it is actually in general a little tricky to turn this into a generic line plot instead of just dots, although if there is interest that could maybe be added later too

@cmdcolin cmdcolin merged commit 1cf1656 into GMOD:master Mar 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment