Adds `fullviewlink` URL param to enable/disable "Full-screen view" link #813

Merged
merged 2 commits into from Mar 22, 2017

Conversation

Projects
None yet
3 participants
@vivekkrish
Contributor

vivekkrish commented Sep 27, 2016

This PR makes available a new URL parameter named fullviewlink, used to control the visibility of the "Full-screen view" button/link.

This is potentially useful in situations where other parameters like nav, overview, tracklist are toggled off (0) to generate an embeddable JBrowse view without any controls, suitable for taking screenshots.

Here is a working example instance on Araport.org, which shows this functionality: https://www.araport.org/locus/AT4G11330/browse?nav=0&overview=0&tracklist=0&fullviewlink=0

CC @keiranmraine

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Mar 22, 2017

Contributor

I think this is a good update and especially nice that it helps that ultra-minimal display setting!

Contributor

cmdcolin commented Mar 22, 2017

I think this is a good update and especially nice that it helps that ultra-minimal display setting!

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Mar 22, 2017

Contributor

Should be good to merge

Contributor

cmdcolin commented Mar 22, 2017

Should be good to merge

@cmdcolin cmdcolin merged commit d539e01 into GMOD:master Mar 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nathandunn

This comment has been minimized.

Show comment
Hide comment
@nathandunn

nathandunn Mar 22, 2017

Contributor

Agreed, was just looking at this thinking how nice it would be to not have it there.

Contributor

nathandunn commented Mar 22, 2017

Agreed, was just looking at this thinking how nice it would be to not have it there.

@vivekkrish

This comment has been minimized.

Show comment
Hide comment
@vivekkrish

vivekkrish Mar 22, 2017

Contributor

Thanks @cmdcolin! 👍

Contributor

vivekkrish commented Mar 22, 2017

Thanks @cmdcolin! 👍

@vivekkrish vivekkrish deleted the Arabidopsis-Information-Portal:add-fullviewlink-url-param branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment