Add list of plugins #848

Merged
merged 2 commits into from Mar 22, 2017

Conversation

Projects
None yet
2 participants
@cmdcolin
Contributor

cmdcolin commented Jan 27, 2017

This allows storing a list of plugins in the About box. The list will scroll also if there are a ton of plugins.

It lists the name of the plugin, and can also add author and url if the plugin adds the "author" and "url" properties to it's main object (e.g. this.url = 'blah', this.author='blah' in plugin constructor)

xref #768

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Jan 27, 2017

Contributor

with/without scrollbox and with author/url listing. the author/url listing would be added by the person who made the plugin in their plugin code as noted above

screenshot-localhost-2017-01-27-00-41-02
screenshot-localhost-2017-01-27-00-41-28
screenshot-localhost-2017-01-27-01-01-00

Contributor

cmdcolin commented Jan 27, 2017

with/without scrollbox and with author/url listing. the author/url listing would be added by the person who made the plugin in their plugin code as noted above

screenshot-localhost-2017-01-27-00-41-02
screenshot-localhost-2017-01-27-00-41-28
screenshot-localhost-2017-01-27-01-01-00

@cmdcolin cmdcolin removed the in progress label Jan 27, 2017

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Mar 22, 2017

Contributor

I guess if this jives with everyone this can be merged too. There is also a noPluginsForAboutDialog option too in case someone really needs it to go away

Contributor

cmdcolin commented Mar 22, 2017

I guess if this jives with everyone this can be merged too. There is also a noPluginsForAboutDialog option too in case someone really needs it to go away

@cmdcolin cmdcolin merged commit a9e68b3 into master Mar 22, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cmdcolin cmdcolin deleted the list_plugins_about_box branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment