Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add histograms argument to the script add-bam-track.pl #972

Merged
merged 3 commits into from Feb 8, 2018
Merged

Add histograms argument to the script add-bam-track.pl #972

merged 3 commits into from Feb 8, 2018

Conversation

loraine-gueguen
Copy link
Contributor

Useful for automatisation in the case where we want to add a lot of BAM files with summary histograms from quantitrative data (bigwig files).

@rbuels rbuels added this to the 1.12.4 milestone Feb 5, 2018
rbuels
rbuels requested changes Feb 6, 2018
View reviewed changes
Copy link
Collaborator

@rbuels rbuels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea, could you rename the option to --bigwigCoverage and make it accept a filename as an argument? Some people might not want to name their bigwig file according to the .bam->.bw convention

@rbuels rbuels added the feature req this adds new functionality to JBrowse 1 label Feb 6, 2018
@nathandunn nathandunn changed the base branch from master to dev February 7, 2018 21:28
@loraine-gueguen
Copy link
Contributor Author

Changes done.

@rbuels rbuels merged commit 3a04425 into GMOD:dev Feb 8, 2018
@rbuels
Copy link
Collaborator

rbuels commented Feb 8, 2018

@loraine-gueguen thank you so much for this!

@loraine-gueguen loraine-gueguen deleted the add_bam_track_script_histograms_arg branch February 26, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuels rbuels rbuels approved these changes

Assignees
No one assigned
Labels
feature req this adds new functionality to JBrowse 1
Projects
None yet
Milestone
1.12.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loraine-gueguen @rbuels