New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NeatCanvasFeatures - restore gradients #985

Merged
merged 8 commits into from Feb 14, 2018

Conversation

Projects
None yet
3 participants
@enuggetry
Contributor

enuggetry commented Feb 13, 2018

Restores gradient features of NeatCanvasFeatures (issue #982)
Cleanup readme.md for both NeatHTMLFeatures and NeatCanvasFeatures

@enuggetry enuggetry added this to the 1.12.4 milestone Feb 13, 2018

@wafflebot wafflebot bot added the in progress label Feb 13, 2018

@rbuels rbuels merged commit e9c13c1 into dev Feb 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Feb 14, 2018

@rbuels rbuels deleted the fix_neatcf branch Feb 14, 2018

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Feb 14, 2018

It doesn't appear to me that gradient features are configurable at least from looking at code. Is the flag ignored?

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Feb 14, 2018

Also what was result of #721 ? Why is this being changed back to gradient on by default?

@enuggetry

This comment has been minimized.

Contributor

enuggetry commented Feb 14, 2018

I'll take a look later today and fix any that needs fixing.

@enuggetry

This comment has been minimized.

Contributor

enuggetry commented Feb 14, 2018

by default the gradients should be on, as that's essentially what the plugin does.

rbuels added a commit that referenced this pull request Feb 14, 2018

Revert "Merge pull request #985 from GMOD/fix_neatcf"
This reverts commit e9c13c1, reversing
changes made to 89bcd35.

@enuggetry enuggetry restored the fix_neatcf branch Feb 15, 2018

enuggetry added a commit that referenced this pull request Feb 28, 2018

collective fixes/additions
consistify gradient on/off config option for NeatCanvasFeatures and NeatHTMLFeatures.
Restore NeatCanvasFeatures gradients #985,#982
add Outrons #992, #931
disable gradiants for alignment tracks #992
fixed uncaught typeerror #992
fixed gradient default NeatHTMLFeatures #992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment