Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #907
I opted for two changes to BAM/LazyParser.js, with associated updates to highlight attributes in Alignments2 menuTemplate:
New next_segment_position_highlight() to return the non-intuitive Location format to cause a single line highlight at the starting base (e.g. Chr01:20..19 will draw a line between bases 19 and 20). Start from feature.get('_next_pos') is incremented from BAM 0-based coordinate to highlight at the correct base.
The existing next_segment_position() function is now only used in Alignments2 menuTemplate title attributes, where again incrementing feature.get('_next_pos') by 1 to get the correct display coordinates in 1-space seems correct.