Alignments2 mate highlight fix #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… string in the format ref:N..N-1 to place a line highlight interbase between N-1 and N; update to add 1 to feature.get('_next_pos') in function next_segment_position, to return single-base ref:N coordinates as 1-based (next_segment_position now only used in menu item titles)
…segment_position_highlight location string (ref:N..N-1 to add a line highlight just before base N)
ghost
assigned 
…ition of the next read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #907
I opted for two changes to BAM/LazyParser.js, with associated updates to highlight attributes in Alignments2 menuTemplate:
New next_segment_position_highlight() to return the non-intuitive Location format to cause a single line highlight at the starting base (e.g. Chr01:20..19 will draw a line between bases 19 and 20). Start from feature.get('_next_pos') is incremented from BAM 0-based coordinate to highlight at the correct base.
The existing next_segment_position() function is now only used in Alignments2 menuTemplate title attributes, where again incrementing feature.get('_next_pos') by 1 to get the correct display coordinates in 1-space seems correct.