New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Configable NeatFeatures & Outrons #992

Closed
wants to merge 7 commits into
base: dev
from

Conversation

Projects
None yet
3 participants
@enuggetry
Contributor

enuggetry commented Feb 16, 2018

Fix #988 Configurable Neat Features
Fix #931 Render Outrons

@enuggetry enuggetry added this to the 1.12.5 milestone Feb 16, 2018

@enuggetry enuggetry self-assigned this Feb 16, 2018

@wafflebot wafflebot bot added the in progress label Feb 16, 2018

@enuggetry enuggetry changed the title from Configable NeatFeatures & Outrons to Merge Configable NeatFeatures & Outrons Feb 16, 2018

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Feb 16, 2018

@enuggetry is this ready to test and review?

@nathandunn

This comment has been minimized.

Contributor

nathandunn commented Feb 16, 2018

I just went through and my only comment is that the default for NeatHTMLFeatures is off and the default for NeatCanvasFeatures is on.

You probably want both off or both on as the default.

However, the configuration and backing text both look great. 💯

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Feb 21, 2018

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Feb 21, 2018

Is there any way we can disable the gradient by default for alignments tracks? The mismatch markers clash terribly with the gradient:

image

@rbuels rbuels added the needs review label Feb 21, 2018

@enuggetry

This comment has been minimized.

Contributor

enuggetry commented Feb 26, 2018

Will work on it.

  • default NeatHTMLFeatures off??
  • type error appendChild
  • disable for alignments

enuggetry added some commits Feb 28, 2018

fix #992
fix - gradients on by default
fix - uncaught type error
fix #992
disable gradients for alignment tracks
Merge origin/fix_neatcf into fix_neatcf
Conflicts:
	plugins/NeatCanvasFeatures/js/main.js

enuggetry added a commit that referenced this pull request Feb 28, 2018

collective fixes/additions
consistify gradient on/off config option for NeatCanvasFeatures and NeatHTMLFeatures.
Restore NeatCanvasFeatures gradients #985,#982
add Outrons #992, #931
disable gradiants for alignment tracks #992
fixed uncaught typeerror #992
fixed gradient default NeatHTMLFeatures #992
@enuggetry

This comment has been minimized.

Contributor

enuggetry commented Feb 28, 2018

Addressed in #1011

@enuggetry enuggetry closed this Feb 28, 2018

@wafflebot wafflebot bot removed the in progress label Feb 28, 2018

@enuggetry enuggetry deleted the fix_neatcf branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment