Permalink
Switch branches/tags
Commits on Mar 24, 2018
  1. Revert "app: tweak sessionrc-expected-2-6 for make check to succeed."

    Jehan
    Jehan committed Mar 24, 2018
    This reverts commit 554347e.
    For some weird reason, this fixed the `make check` but broke the `make
    distcheck`. I am lost. Better revert, and now distcheck works great.
  2. app: tweak sessionrc-expected-2-6 for make check to succeed.

    Jehan
    Jehan committed Mar 24, 2018
    I'm not sure how useful is this test if we have to just constantly tweak
    the sessionrc for it to pass. But well… here it is.
    Now make check fully passes.
  3. app, po: revert commit a072478 and add a TRANSLATORS comment.

    Jehan
    Jehan committed Mar 24, 2018
    Not using %d in the singular form of English does not prevent other
    languages to use %d in any form they wish to. This will still work and
    will still be replaced by the relevant number of images.
    So I revert commit a072478 because it is just prettier (in English)
    to write "An image" rather than "1 image", but this does not mean you
    have to do the same in other languages! Adding a comment so that
    translators know about it.
    
    Also directly modify the msgid in the Polish and Russian translations
    which already translated this string, so that the translations does not
    end up unnecessarily fuzzy.
  4. Update Polish translation

    piotrdrag committed Mar 24, 2018
  5. app: shorten to "Debug Policy" the long label in Preferences.

    Jehan
    Jehan committed Mar 24, 2018
    The text was too long and increasing the minimum width of Preferences
    dialog.
Commits on Mar 23, 2018
  1. Update Russian translation

    prokoudine committed Mar 23, 2018
  2. Update Polish translation

    piotrdrag committed Mar 23, 2018
  3. Update Polish translation

    piotrdrag committed Mar 23, 2018
  4. Update Polish translation

    piotrdrag committed Mar 23, 2018
  5. Update Polish translation

    piotrdrag committed Mar 23, 2018
  6. Bug 794634 - CRITICAL when adding layers with Dissolve mode

    Ell
    Ell committed Mar 23, 2018
    Fix a CRITICAL when calling gimp_layer_mode_get_format() with an
    AUTO composite space and a NULL preferred format, which is valid:
    it means the layer mode is composite-space agnostic (as DISSOLVE
    is), and that there's no preferred format.
    
    A NULL preferred format can occur during
    gimp_operation_layer_mode_prepare() if the layer's mode node is not
    yet attached anything through its "input" or "aux" pads, which is
    the case during the call to gimp_layer_update_mode_node() while
    constructing the layer's node in gimp_layer_get_node().
  7. depend on GEGL 0.3.30

    hodefoting committed Mar 23, 2018
  8. Bug 794469 - Shift-click-create layer always set "Default/Normal" mode.

    Jehan
    Jehan committed Mar 23, 2018
    It should use the last used layer mode instead.
  9. Bug 794221 - Recently used colors on text don't get added to the colo…

    mitchfoo committed Mar 23, 2018
    …r history
    
    Add signal GimpTextBuffer::color-applied which is emitted when text is
    inserted or when color is applied to a span of text.
    
    In GimpTextTool, connect to the signal and update the global color
    history.
    
    Unrelated: rename gimp_text_tag_get_color() to get_fg_color() and add
    boolean return values to get_fg_color() and get_fg_color() which
    indicates if a color is set on the tag at all. This ended up unneeded
    in the fix but is an improvement regardless.
  10. NEWS: keep up-to-date.

    Jehan
    Jehan committed Mar 23, 2018
Commits on Mar 22, 2018
  1. app: output a dialog to recover images salvaged after a crash.

    Jehan
    Jehan committed Mar 22, 2018
    Since commit d916fed, GIMP has had the hidden feature to salvage
    images (if possible) during a crash into a backup folder. This commit
    finishes the feature by opening a dialog proposing to try and recover
    the salvaged images.
    This is not perfect yet since it doesn't "remember" the XCF path (in
    case it was a previously saved image). The images open as new unsaved
    and dirty images, but directly from the contents at crash time. For now,
    it is up to people to figure out what they correspond to, if relevant.
  2. Bug 793734 - White alpha border after upscaling

    Ell
    Ell committed Mar 22, 2018
    In gimp_gegl_apply_scale(), use a CLAMP abyss policy for the scale
    op, to avoid leaking transparency into the image when scaling
    drawables.
    
    Note that this (intentionally) only affects whole-image/layer
    scaling, and not scaling done using any of the transform tools.
  3. app: crop input to output rect in channel ops

    Ell
    Ell committed Mar 22, 2018
    In gimp_gegl_apply_{border,grow,shrink,flood}(), which are used
    by the corresponding channel functions, pass crop_input = TRUE to
    gimp_gegl_apply_operation(), to clip the input to the output rect.
    
    These operations process the entire input in one go, regardless of
    the requested output region; however, the channel functions
    calculate the output region according to the known channel bounds,
    hence clipping the input to these bounds doesn't affect discard any
    information, while avoiding unnecessary work.  In particular, this
    makes the corresponding operations on small selections in big images
    much faster.
  4. app: add crop_input parameter to gimp_gegl_apply_operation()

    Ell
    Ell committed Mar 22, 2018
    Add a crop_input parameter to gimp_gegl_apply_[cached_]operation().
    When TRUE, the functions crop the op's input to the destination
    rect.  This is particularly useful for functions that process the
    entire input in one go (by means of get_cached_region()).  See the
    next commit.
    
    Pass crop_input = FALSE at all call sites for now, to keep the
    current behavior.
  5. app, NEWS: metadata export settings are now ON by default.

    Jehan
    Jehan committed Mar 22, 2018
    After many discussions, it has been decided to export the metadata by
    default since it seems to be what many people would expect and they
    would consider they "lost" metadata (especially if they overwrite their
    original). I don't entirely agree since privacy (particularly if you are
    not aware of metadata and information they may contain) is also an issue
    but not many seem to agree with me.
    So here it is! All metadata now exported as a default!
  6. autogen: add support for recent automake 1.16.

    Jehan
    Jehan committed Mar 22, 2018
  7. app: only show FATAL errors by default for stable releases.

    Jehan
    Jehan committed Mar 20, 2018
    The debug dialog is awesome and extremely helpful, but I realize it may
    be a better default experience on *stable* to raise it only in case of
    crashes. CRITICAL are bad and should be fixed, but sometimes their
    consequence is actually not visible except for this dialog, and people
    on stable builds may prefer not to see this dialog. Also we will likely
    get a lot of duplicates for the same bugs once everybody has this by
    default, which will be very annoying to attend to, unless we had
    automation (which we don't right now).
    The option is still available in preferences anyway so people really
    interested in helping can activate the option for CRITICAL and even
    WARNING anyway, even on stable releases.
Commits on Mar 21, 2018
Commits on Mar 20, 2018
  1. Bug 794378 - GIMP crashed while I was moving the image window

    mitchfoo committed Mar 20, 2018
    Use a weak pointer in GimpToolGui to not keep a dangling
    private->viewable around.
  2. NEWS: keep up-to-date.

    Jehan
    Jehan committed Mar 20, 2018
  3. plug-ins: rename s/YUV/YCbCr/ s/eYCC/xvYCC/ s/RGB/sRGB/.

    Jehan
    Jehan committed Mar 20, 2018
    Exchanging with OpenJPEG developers and searching more on the topic, it
    seems that YUV is more often refered to as YCbCr. Wikipedia says:
    
    > typically the terms YCbCr and YUV are used interchangeably, leading to
    > some confusion. The main difference is that YUV is analog and YCbCr is
    > digital
    
    As for eYCC, I am told this is extended YCC. It seems this is refered as
    xvYCC (I really can't find much under "eYCC"). So let's rename it too.
    
    Hopefully I made no mistakes!
  4. plug-ins: add a color space parameter to file-j2k-load().

    Jehan
    Jehan committed Mar 20, 2018
    JPEG 2000 codestream doesn't have a header and guessing the color space
    in particular is not foolproof (especially when 3 or 4 components, which
    can be many spaces). Therefore the need of a parameter on the API.
    
    Note that JP2 images should always have the color space information. In
    interactive mode, I try to be a bit flexible to salvage broken JP2 with
    no color space information in the header, but I am not adding a
    parameter in file-jp2-load() (on purpose, since we are not going to add
    in the API a parameter for a case not supposed to happen with properly
    encoded files).
  5. plug-ins: open a dialog to select color space of JPEG 2000 codestream.

    Jehan
    Jehan committed Mar 20, 2018
    JPEG 2000 codestream (.j2k/.j2c) are only compressed code stream data,
    without header. In particular we don't have color information, such as
    the color space. So we need to open a dialog asking to set the color
    space in interactive mode.
    
    Note: according to OpenJPEG developers, a JP2 image (not codestream)
    should always have a color space defined in its header. But just to be
    flexible, the same dialog may get raised as well if we try to load a JP2
    with no valid color space defined in header and no ICC profile embedded.
    Maybe if such a thing happened, it means the image is corrupt, yet we
    may as well try and salvage it anyway.
    
    Note 2: I also removed a weird test which was setting some images as
    being YUV color space by mistake. This actually fixes bug 794413 as a
    side effect.
  6. plug-ins: .jpc is another known extension for JPEG 2000 codestream.

    Jehan
    Jehan committed Mar 20, 2018
    Even though I haven't seen working samples with this extension,
    according to some references, this is a common extension for compressed
    JPEG 2000 code stream. Also our old plug-in was listing this extension,
    so let's do so now as well.
    
    To this day, the only 2 extensions we used to list in the JasPer-based
    plug-in and not in the OpenJPEG one are .jpf and .jpx (JPEG 2000 Part-2)
    since OpenJPEG does not have support yet. But actually I think the old
    plug-in may have simply been "lying" since JasPer website says the
    library is meant to implement JPEG-2000 Part-1 standard.
    So I believe we are now on par (and even better on many aspects) with
    the former plug-in implementation based on libjasper.
Commits on Mar 19, 2018
  1. Bug 792686 - Colormap widget not updated when adding entry

    mitchfoo committed Mar 19, 2018
    gimp_image_add_colormap_entry(): increment private->n_colors *before*
    calling gimp_image_colormap_set_palette_entry() so it actually adds an
    entry.
  2. Bug 783680 - Allow to hide color models in GimpColorScales

    mitchfoo committed Mar 19, 2018
    Redo the entire thing again:
    
    - Rename the values of enum GimpColorSelectorModel to include "MODEL"
    - Change GimpColorSelector API from set_model() to set_model_visible()
      so visibility of each model can be toggled individually and is not
      exclusive any longer
    - The GUI is back to what it was before, except that the "GIMP" page
      now honors the model visibility and has a resonable minimum height