/gnome-music

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Last.fm integration #5

Closed
wants to merge 8 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nilgradisnik @davidgumberg
@nilgradisnik

nilgradisnik commented Jan 3, 2015

Implemented last.fm service integration.
Posting nowPlaying and scrobble events.
Added toggle action to app menu.

Using the following new modules:

  • json
  • hashlib
  • urllib

TODO: Pass last.fm API key and secret to constructor in application.py:144

nilgradisnik added some commits Dec 31, 2014

@nilgradisnik
Initial last.fm scrobble implementation. 
Working authenticate and scrobble methods. Updated dconf schema with
lastfm-session and lastfm-scrobble keys.
6bb7e6c
@nilgradisnik
Added nowPlaying method. 
Now playing method notifies last.fm that a user has started listening to
a track.
8ecd2ad
@nilgradisnik
Track method cleanup.
27a0723
@nilgradisnik
Added session check max count. 
To avoid infinite checking. With current parameters 5s and max count 10
it will check for session key for 50s and then bail out.
4546e59
@nilgradisnik
Application integration added. Listening to lastfm-scrobble signal. 
Added new gobject signal 'lastfm-scrobble' to trigger last.fm scrobble
event. Happens in player.load method and gets triggered only if
lastfm-scrobble setting is true and track duration is more than 30s.

Reimplemented lastfm module to listen to this signal and publish now
playing event and in half track time publish scrobble event.

TODO: pass API key and secret to the constructor located in application.
.
f4f8d55
@nilgradisnik
More error handling.
de04d75
@nilgradisnik
Added last.fm toggle action to app menu.
bd29bf2
@davidgumberg
Contributor

davidgumberg commented Jan 4, 2015

Hi, this is an awesome change, but the gnome github repositories are merely mirrors. There are instructions on how to contribute changes at: https://wiki.gnome.org/GnomeLove/SubmittingPatches . Please let me know if you need any help!
@nilgradisnik

nilgradisnik commented Jan 4, 2015

Thanks for the info. I'll submit a patch when I get the chance.

@nilgradisnik nilgradisnik closed this Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment