New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Solarized palette #6

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@jamjury

jamjury commented Jan 12, 2018

All other default palettes make ${USER}@${HOSTNAME} green and ${PWD} blue, but with
Solarized everything is grey. I think, those colors should be somewhat consistent.
Swap normal and bright colors to fix it.

Screenshots:
Current Solarized palette
If applied, this commit will change it to following

Other palettes:
Tango
Linux console
XTerm

Fix Solarized palette
All other default palettes make whoami@hostname green and pwn blue, but with
Solarized everything is grey.
Swap normal and bright colors to fix this.
@gnomesysadmins

This comment has been minimized.

Contributor

gnomesysadmins commented Jan 13, 2018

Thank you for contributing to gnome-terminal!

gnome-terminal uses Bugzilla for code review.

If you have never contributed to GNOME before make sure you have read the
getting started documentation:
http://www.gnome.org/get-involved

Otherwise please visit
https://wiki.gnome.org/Newcomers
and follow the instructions there to upload your change to Bugzilla.

@egmontkob

This comment has been minimized.

Contributor

egmontkob commented May 1, 2018

Solarized palette is defined on its homepage, the URL is even present in your patch. Please see the specs over there, compare with gnome-terminal's implementation, and let us know if you find any difference.

Solarized is not a color scheme which keeps traditional green as green and traditional blue as blue. If that's what you expect, that's a false expectation, and you should probably stick to another color scheme.

@egmontkob

This comment has been minimized.

Contributor

egmontkob commented May 1, 2018

Oh, by the way... upgrade to gnome-terminal 3.28 and disable the "Show bold text in bright colors" option on its color settings tab. Probably this is what confused you. This is indeed something that was missing from gnome-terminal for a long time, to get you real colors rather than gray ones.

@egmontkob

This comment has been minimized.

Contributor

egmontkob commented May 2, 2018

I just realized that my first comment might have come across as a bit harsh, sorry in that case, I didn't mean that, I was simply quite tired yesterday.

Submitted https://git.gnome.org/browse/gnome-terminal/commit/?id=e8ee9f786 to make it more obvious that we indeed define the Solarized palette correctly.

As per my second comment, the brand new "Show bold text in bright colors" option is probably what you're looking for.

gnomesysadmins pushed a commit that referenced this pull request Jun 15, 2018

icons: shipp app icon
- fullcolor & symbolic app icons

Fixes issue #6

gnomesysadmins pushed a commit that referenced this pull request Jun 15, 2018

icons: shipp app icon
- fullcolor & symbolic app icons

Fixes issue #6

gnomesysadmins pushed a commit that referenced this pull request Jun 15, 2018

icons: shipp app icon
- fullcolor & symbolic app icons

Fixes issue #6

gnomesysadmins pushed a commit that referenced this pull request Jun 19, 2018

gnomesysadmins pushed a commit that referenced this pull request Jun 25, 2018

gnomesysadmins pushed a commit that referenced this pull request Oct 31, 2018

icon: update app icon
- GNOME 3.32 redesign of app icons.
  See https://gitlab.gnome.org/GNOME/Initiatives/issues/2
  for more info.

/label ~"9. Initiative: AppIconRedesign"

Fixes issue #6

gnomesysadmins pushed a commit that referenced this pull request Oct 31, 2018

icon: update app icon
- GNOME 3.32 redesign of app icons.
  See https://gitlab.gnome.org/GNOME/Initiatives/issues/2
  for more info.

/label ~"9. Initiative: AppIconRedesign"

Fixes issue #6

gnomesysadmins pushed a commit that referenced this pull request Nov 3, 2018

icon: update app icon
- GNOME 3.32 redesign of app icons.
  See https://gitlab.gnome.org/GNOME/Initiatives/issues/2
  for more info.

/label ~"9. Initiative: AppIconRedesign"

Fixes issue #6

gnomesysadmins pushed a commit that referenced this pull request Nov 10, 2018

icon: update app icon
- GNOME 3.32 redesign of app icons.
  See https://gitlab.gnome.org/GNOME/Initiatives/issues/2
  for more info.

/label ~"9. Initiative: AppIconRedesign"

Fixes issue #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment