Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure GFile is unreferenced to avoid filename memory leak #3

Closed
wants to merge 1 commit into from
Closed

Ensure GFile is unreferenced to avoid filename memory leak #3

wants to merge 1 commit into from

Conversation

lovell
Copy link
Contributor

@lovell lovell commented Jan 6, 2018

Hello @federicomenaquintero, thank you very much for all the time you continue to devote to librsvg.

v2.40.20 appears to have introduced a small memory leak of the filename that I think was via the change in commit 475764f

The change in this PR should ensure the GFile instance is unreferenced for all paths.

(The Gnome GitLab instance won't let me register - "Email is not from an allowed domain" - hence the use of GitHub.)

@lovell lovell changed the title Ensure GFile is unreferenced to avoid 162 byte leak Ensure GFile is unreferenced to avoid filename memory leak Jan 6, 2018
@gnomesysadmins
Copy link

Thank you for contributing to librsvg!

librsvg uses Bugzilla for code review.

If you have never contributed to GNOME before make sure you have read the
getting started documentation:
http://www.gnome.org/get-involved

Otherwise please visit
https://wiki.gnome.org/Newcomers
and follow the instructions there to upload your change to Bugzilla.

@federicomenaquintero
Copy link
Contributor

Thanks for noticing this! I'll review this on Monday. Please ignore the auto-closing bot - GNOME's gihub mirror is configured to disallow pull requests, but I'm happy to look at them.

(If you want to send a pull request in the future, we have https://gitlab.gnome.org/GNOME/librsvg - you can create an account there and have a similar workflow to here.)

@lovell
Copy link
Contributor Author

lovell commented Jan 7, 2018

@federicomenaquintero Thank you.

I've now been able to register with gitlab.gnome.org using a gmail.com address so I guess there are restrictions in place. Given I was able to change to a non-gmail address as soon as I was registered suggests those restrictions could probably be removed.

I'll open a merge request there now.

@lovell lovell deleted the librsvg-2.40-leak-rsvg_handle_new_from_file branch January 7, 2018 09:27
@lovell
Copy link
Contributor Author

lovell commented Jan 7, 2018

gnomesysadmins pushed a commit that referenced this pull request Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants