New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: Patch for Ispell.el to improve UTF-8 support, misc. #142

Open
aspell-helper opened this Issue Apr 30, 2004 · 11 comments

Comments

Projects
None yet
1 participant
@aspell-helper
Collaborator

aspell-helper commented Apr 30, 2004

J. J. Ramsey <jjramsey@sf> created a patch on 2004-04-30 15:59:54 UTC
(Orig. from https://sourceforge.net/p/aspell/patches/24)

I've attached a compressed diff that will apply cleanly
against the Ispell.el 3.7 beta dated 22 Sept 2003,
available from
http://www.kdstevens.com/~stevens/ispell-page.html.
If need be, it should not be hard to backport it to
Ispell.el 3.6, although as far as I can tell, what made
Ispell.el 3.7 a "beta" was that it used a couple
functions that were defined in the Ispell.el
maintainer's setup, but not by all Emacs users, and
those problems are fixed by this patch. The features of
the patch:

* If the "ispell" used by Emacs is really a version of
Aspell 0.50 or greater, then by default the encoding to
pass strings to and from the Ispell process is whatever
encoding Emacs uses to display the file being spell
checked. UTF-8 support is only available for Aspell
0.60 or better, and it works for Aspell 0.60
pre-release snapshots dated after 24 Apr 2004. This
feature can be turned off by setting
ispell-auto-detect-encoding to nil.

* By default the casechars, non-casechars, and
otherchars are determined from the encoding returned by
ispell-get-coding-system. I tried so set things up so
that foreign letters (i.e. accented characters)
would not be mistaken for word separators by the
ispell-word function or Flyspell. This feature can be
turned off by setting ispell-auto-detect-casechars to nil.

* The feature from the patch at
ftp://ftp.gnu.org/gnu/aspell/ispell.el-aspell-0.1.diff,
where Aspell is notified "of the replacements you make
so it can improve the suggestion list in the future",
has been integrated into this patch. Since for Aspell
to keep a record of replacements the personal
dictionary has to be saved, and apparently not all
Ispell.el users want this, this feature can be turned
off by setting
ispell-aspell-learn-from-user-misspelling to nil.

@aspell-helper

This comment has been minimized.

Show comment
Hide comment
@aspell-helper

aspell-helper Apr 30, 2004

Collaborator

J. J. Ramsey <jjramsey@sf> commented on 2004-04-30 15:59:55 UTC

Patch for ispell.el 3.7 beta
ispell.diff.gz

Collaborator

aspell-helper commented Apr 30, 2004

J. J. Ramsey <jjramsey@sf> commented on 2004-04-30 15:59:55 UTC

Patch for ispell.el 3.7 beta
ispell.diff.gz

@aspell-helper

This comment has been minimized.

Show comment
Hide comment
@aspell-helper

aspell-helper May 14, 2004

Collaborator

Kevin Atkinson <kevina@sf> updated the issue on 2004-05-14 20:29:58 UTC

  • assigned_to: nobody --> kevina
Collaborator

aspell-helper commented May 14, 2004

Kevin Atkinson <kevina@sf> updated the issue on 2004-05-14 20:29:58 UTC

  • assigned_to: nobody --> kevina
@aspell-helper

This comment has been minimized.

Show comment
Hide comment
@aspell-helper

aspell-helper Oct 22, 2004

Collaborator

Kevin Atkinson <kevina@sf> commented on 2004-10-22 12:27:15 UTC

Logged In: YES
user_id=6591

Have you sumitted this to Ken Stevens?

PS: I finally added a link to this patch at http://aspell.net/

Collaborator

aspell-helper commented Oct 22, 2004

Kevin Atkinson <kevina@sf> commented on 2004-10-22 12:27:15 UTC

Logged In: YES
user_id=6591

Have you sumitted this to Ken Stevens?

PS: I finally added a link to this patch at http://aspell.net/

@aspell-helper

This comment has been minimized.

Show comment
Hide comment
@aspell-helper

aspell-helper Oct 22, 2004

Collaborator

J. J. Ramsey <jjramsey@sf> commented on 2004-10-22 15:10:07 UTC

Logged In: YES
user_id=156375

Have you sumitted this to Ken Stevens?

Yes, quite a while ago?

Collaborator

aspell-helper commented Oct 22, 2004

J. J. Ramsey <jjramsey@sf> commented on 2004-10-22 15:10:07 UTC

Logged In: YES
user_id=156375

Have you sumitted this to Ken Stevens?

Yes, quite a while ago?

@aspell-helper

This comment has been minimized.

Show comment
Hide comment
@aspell-helper

aspell-helper Dec 31, 2004

Collaborator

J. J. Ramsey <jjramsey@sf> commented on 2004-12-31 05:28:31 UTC

Logged In: YES
user_id=156375

In the last revision, the regular expression used to
determine what characters belong to a word was by default
determined by the encoding Emacs uses to display the file
being spell checked. This is still the case; however, Emacs
21.3.50 complained of ranges straddling charsets, so now the
regular expression only covers characters in Latin-based
languages. :( I'm not sure if the bug is in 21.3.50 or in
the regular expression I had before.

Collaborator

aspell-helper commented Dec 31, 2004

J. J. Ramsey <jjramsey@sf> commented on 2004-12-31 05:28:31 UTC

Logged In: YES
user_id=156375

In the last revision, the regular expression used to
determine what characters belong to a word was by default
determined by the encoding Emacs uses to display the file
being spell checked. This is still the case; however, Emacs
21.3.50 complained of ranges straddling charsets, so now the
regular expression only covers characters in Latin-based
languages. :( I'm not sure if the bug is in 21.3.50 or in
the regular expression I had before.

@aspell-helper

This comment has been minimized.

Show comment
Hide comment
@aspell-helper

aspell-helper Dec 31, 2004

Collaborator

J. J. Ramsey <jjramsey@sf> commented on 2004-12-31 18:05:47 UTC

Logged In: YES
user_id=156375

Fixed (?) the regular expression used to determine what
characters belong to a word when the encoding is UTF-8--at
least I got it to the "works for me" stage. It should now
nominally cover all the languages Emacs and Aspell support,
even in Emacs 21.3.50. There seems to be some oddities in
Emacs 21.3.50 that affect how it handles CJK charsets.

Collaborator

aspell-helper commented Dec 31, 2004

J. J. Ramsey <jjramsey@sf> commented on 2004-12-31 18:05:47 UTC

Logged In: YES
user_id=156375

Fixed (?) the regular expression used to determine what
characters belong to a word when the encoding is UTF-8--at
least I got it to the "works for me" stage. It should now
nominally cover all the languages Emacs and Aspell support,
even in Emacs 21.3.50. There seems to be some oddities in
Emacs 21.3.50 that affect how it handles CJK charsets.

@aspell-helper

This comment has been minimized.

Show comment
Hide comment
@aspell-helper

aspell-helper Dec 31, 2004

Collaborator

J. J. Ramsey <jjramsey@sf> commented on 2004-12-31 22:29:59 UTC

Revised patch for ispell.el 3.7 beta for Emacs 21.3.50
ispell.diff.gz

Collaborator

aspell-helper commented Dec 31, 2004

J. J. Ramsey <jjramsey@sf> commented on 2004-12-31 22:29:59 UTC

Revised patch for ispell.el 3.7 beta for Emacs 21.3.50
ispell.diff.gz

@aspell-helper

This comment has been minimized.

Show comment
Hide comment
@aspell-helper

aspell-helper Jan 27, 2005

Collaborator

J. J. Ramsey <jjramsey@sf> commented on 2005-01-27 15:38:01 UTC

Logged In: YES
user_id=156375

If the coding-system of the buffer was set to nil,
Ispell-mode would die with the error "coding-system-get:
Wrong type argument: arrayp, nil". This problem should be fixed.

Collaborator

aspell-helper commented Jan 27, 2005

J. J. Ramsey <jjramsey@sf> commented on 2005-01-27 15:38:01 UTC

Logged In: YES
user_id=156375

If the coding-system of the buffer was set to nil,
Ispell-mode would die with the error "coding-system-get:
Wrong type argument: arrayp, nil". This problem should be fixed.

@aspell-helper

This comment has been minimized.

Show comment
Hide comment
@aspell-helper

aspell-helper Jan 27, 2005

Collaborator

J. J. Ramsey <jjramsey@sf> commented on 2005-01-27 15:38:02 UTC

Patch for ispell.el 3.7 beta to fix "Wrong type argument" error
ispell-new.diff.gz

Collaborator

aspell-helper commented Jan 27, 2005

J. J. Ramsey <jjramsey@sf> commented on 2005-01-27 15:38:02 UTC

Patch for ispell.el 3.7 beta to fix "Wrong type argument" error
ispell-new.diff.gz

@aspell-helper

This comment has been minimized.

Show comment
Hide comment
@aspell-helper

aspell-helper Apr 1, 2005

Collaborator

Agustin Martin Domingo <agmartin@sf> commented on 2005-04-01 10:43:26 UTC

Logged In: YES
user_id=368139

Looks like mime-charset is not a coding-system property for
xemacs,
Something like

(if (featurep 'xemacs)
(coding-system-name
(coding-system-base (ispell-get-coding-system)))
(coding-system-get (ispell-get-coding-system) 'mime-charset))

seems to work, although for 'no-conversion' will return
raw-text where I think emacs returns nil. I do not know if
there is a better way for this,

Collaborator

aspell-helper commented Apr 1, 2005

Agustin Martin Domingo <agmartin@sf> commented on 2005-04-01 10:43:26 UTC

Logged In: YES
user_id=368139

Looks like mime-charset is not a coding-system property for
xemacs,
Something like

(if (featurep 'xemacs)
(coding-system-name
(coding-system-base (ispell-get-coding-system)))
(coding-system-get (ispell-get-coding-system) 'mime-charset))

seems to work, although for 'no-conversion' will return
raw-text where I think emacs returns nil. I do not know if
there is a better way for this,

@aspell-helper

This comment has been minimized.

Show comment
Hide comment
@aspell-helper

aspell-helper Jun 26, 2011

Collaborator

Kevin Atkinson <kevina@sf> updated the issue on 2011-06-26 04:26:19 UTC

  • milestone: --> other
Collaborator

aspell-helper commented Jun 26, 2011

Kevin Atkinson <kevina@sf> updated the issue on 2011-06-26 04:26:19 UTC

  • milestone: --> other
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment