Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3319: Adds the word space preference #20

Merged
merged 9 commits into from Oct 22, 2018

Conversation

Projects
None yet
2 participants
@jobara
Copy link
Collaborator

commented Oct 17, 2018

@jobara

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 17, 2018

@amb26 would you be able to review this PR to add the word space preference to UIO+?

@amb26

This comment has been minimized.

Copy link
Member

commented Oct 22, 2018

This pull itself is fine, but I did note in the coverage data that this function appears to be uncovered: https://github.com/GPII/gpii-chrome-extension/blob/master/extension/src/lib/domSettingsApplier.js#L89

@amb26 amb26 merged commit 187e719 into GPII:master Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.