Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3567: Corrected the contrast panel configuration #28

Merged
merged 3 commits into from Dec 7, 2018

Conversation

Projects
None yet
2 participants
@jobara
Copy link
Collaborator

commented Dec 5, 2018

Fixed the contrast panel configuration to assign the correct labels to the each theme option.

Also added the publishing information to the README. When this is merged we should change the GPII Wiki to point at the README instead of having the documentation duplicated there.

https://issues.gpii.net/browse/GPII-3567

@jobara

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 5, 2018

@cindyli would you be able to review this PR. We should also publish a new release afterwards.

README.md Outdated
3. Test all of the preferences and ensure that they apply to web page content correctly.
1. Refresh any Browser Tabs/Windows that were open prior to installing the extension.
2. The preferences should be tested individually and in combinations to ensure that interactions between the
preferences are working properly. For example (Text-To-Speech and Syllabification).

This comment has been minimized.

Copy link
@cindyli

cindyli Dec 6, 2018

Contributor

In the For example, shall "Text to speech with reading mode" be added? On my notes, this is another case that should be tested specifically.

2. The preferences should be tested individually and in combinations to ensure that interactions between the
preferences are working properly. For example (Text-To-Speech and Syllabification).
3. Multiple web pages should be tested. However, not all preferences will work with all sites. For example,
YouTube captions will only work with YouTube videos embedded using the iframe API and providing captions

This comment has been minimized.

Copy link
@cindyli

cindyli Dec 6, 2018

Contributor

Would be nice to add the exemplary youtube video you created here to provide a testable case for youtube captions.

number/name, descriptions, screenshots and etc.
8. When everything appears correct, publish the changes.
1. The actual publishing to the Chrome Web Store will take about an hour.
9. Tag the master branch with the release (e.g. v0.1.0-beta.10)

This comment has been minimized.

Copy link
@cindyli

cindyli Dec 6, 2018

Contributor

Does it make sense to add one more step after this for creating a release in the github repo based on the new tag?

@jobara

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 7, 2018

@cindyli I've added the additional information as requested. Ready for more review.

@cindyli cindyli merged commit a7a710b into GPII:master Dec 7, 2018

@cindyli

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2018

Merged at 224e7fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.