Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-4235: Setting up CI configuration #40

Merged
merged 1 commit into from Dec 5, 2019
Merged

GPII-4235: Setting up CI configuration #40

merged 1 commit into from Dec 5, 2019

Conversation

@jobara
Copy link
Collaborator

jobara commented Nov 28, 2019

  • added a CI workflow
  • added badge to README
  • removed zoom tests from running in the browser.
  • updated testem config
  • updated dependencies
  • updated editorconfig

https://issues.gpii.net/browse/GPII-4235

- added a CI workflow
- added badge to README
- removed zoom tests from running in the browser.
- updated testem config
- updated dependencies
- updated editorconfig
@jobara

This comment has been minimized.

Copy link
Collaborator Author

jobara commented Nov 28, 2019

@amb26 could you please review this PR?

@amb26

This comment has been minimized.

Copy link
Member

amb26 commented Dec 4, 2019

I tried this on my baremetal Windows machine and got a strange failure from testem:

18:20:52.565:  Registering module gpii-express from path E:\source\gits\gpii-chrome-extension\node_modules\gpii-express
18:20:53.311:  FATAL ERROR: Uncaught exception: Relogin from an unknown browser Firefox 70.0 with id null
Error: Relogin from an unknown browser Firefox 70.0 with id null
    at App.onBrowserRelogin (E:\source\gits\gpii-chrome-extension\node_modules\testem\lib\app.js:280:13)
    at Server.emit (events.js:182:13)
    at Socket.client.once (E:\source\gits\gpii-chrome-extension\node_modules\testem\lib\server\index.js:394:12)
    at Object.onceWrapper (events.js:273:13)
    at Socket.emit (events.js:182:13)
    at E:\source\gits\gpii-chrome-extension\node_modules\socket.io\lib\socket.js:528:12
    at process._tickCallback (internal/process/next_tick.js:61:11)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! ui-options-chrome@0.1.0 test:browser: `node node_modules/testem/testem.js ci --file tests/browser/testem.js`
npm ERR! Exit status 1
@jobara

This comment has been minimized.

Copy link
Collaborator Author

jobara commented Dec 4, 2019

@amb26 I have randomly seen that in the Windows test runs, although re-running the tests usually cleared it up. I'll see if I can find any more information though.

@amb26

This comment has been minimized.

Copy link
Member

amb26 commented Dec 4, 2019

I've tried it 4 times and got 4 failures in a row now. Oddly I don't see any attempt to actually start up a Firefox window.

@jobara

This comment has been minimized.

Copy link
Collaborator Author

jobara commented Dec 4, 2019

@amb26 the HEADLESS environment variable is set so that Chrome will run headless, but I think it's also making Firefox run headless. I wonder if it's that Firefox is having trouble with that on Windows

@jobara

This comment has been minimized.

Copy link
Collaborator Author

jobara commented Dec 4, 2019

Although this testem issue filed by @the-t-in-rtf would suggest that it should work better when headless testem/testem#1377

@jobara

This comment has been minimized.

Copy link
Collaborator Author

jobara commented Dec 4, 2019

@the-t-in-rtf

This comment has been minimized.

Copy link
Member

the-t-in-rtf commented Dec 5, 2019

OK,

Environment Headed Headless
OS X Catalina ✔️ ✔️
Linux VM ✔️ ✔️
Windows 10 VM ✔️ ✔️

The check minus for "headed" is because I had to close Firefox manually, I'd have to leave it to see if it eventually times out. So, I don't really have an environment where I can troubleshoot this further.

@amb26, if you set the HEADLESS environment variable ala $Env:HEADLESS = "true" before running npm test, do the tests pass for you?

@amb26

This comment has been minimized.

Copy link
Member

amb26 commented Dec 5, 2019

It didn't make any difference - only the different id reported in the line

13:29:28.367:  FATAL ERROR: Uncaught exception: Relogin from an unknown browser Firefox 70.0 with id 36628477205360784

However, I got a clue once I tried closing, restarting and updating firefox a few times. I discovered that, while Firefox itself had got updated to version 71, interestingly, the messages from the phantom "relogin" stayed at version 70. Eventually a hunt revealed that there was a cluster of invisible zombie Firefox processes running on the system, perhaps left over from some previous testem run, which must have been causing the "relogin"

@amb26 amb26 merged commit 5c58711 into GPII:master Dec 5, 2019
@amb26

This comment has been minimized.

Copy link
Member

amb26 commented Dec 5, 2019

Sorry for wasting everyone's time with this

@the-t-in-rtf

This comment has been minimized.

Copy link
Member

the-t-in-rtf commented Dec 5, 2019

No worries, that's actually a thing that could commonly happen on any actively-used Windows instance, and good to know about.

@jobara

This comment has been minimized.

Copy link
Collaborator Author

jobara commented Dec 5, 2019

I suppose the similar issues I noticed occasionally on CI may have been related to Firefox being updated around the time the test launched the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.