New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPII-3457: Update to work with newer versions of Testem. #18
Conversation
If anyone would like to try this out, there's now a dev release: 2.1.10-dev.20190404T122608Z.b51705e.GPII-3457 |
CI job failed: https://ci.gpii.net/job/gpii-testem-tests/1/ |
OK to test. |
CI job failed: https://ci.gpii.net/job/gpii-testem-tests/2/ |
Ok to test. |
CI job failed: https://ci.gpii.net/job/gpii-testem-tests/3/ |
ok to test. |
CI job failed: https://ci.gpii.net/job/gpii-testem-tests/4/ |
Ok to test. |
CI job failed: https://ci.gpii.net/job/gpii-testem-tests/5/ |
The last tests timed out oddly. Ok to test. |
CI job failed: https://ci.gpii.net/job/gpii-testem-tests/6/ |
CI job failed: https://ci.gpii.net/job/gpii-testem-tests/7/ |
The build was aborted. Ok to test. |
I suspect this will time out or be aborted:
I will verify things working locally shortly. |
CI job failed: https://ci.gpii.net/job/gpii-testem-tests/8/ |
Same hang in a local Vagrant VM, investigating now. |
…ork with the latest chromedriver.
The tests that were hanging were the gpii-webdriver based tests of the "rollup" without Testem. Looks like CI hit the same problem that @amb26 and I were discussing a week or so ago, i.e. if you have the latest chromedriver, you also have to have the latest Chrome. I added a step to the VM provisioning to update Chrome, which hopefully will fix the tests. |
CI job passed: https://ci.gpii.net/job/gpii-testem-tests/9/ |
CI job passed: https://ci.gpii.net/job/gpii-testem-tests/10/ |
src/js/testem-component.js
Outdated
@@ -463,7 +452,7 @@ fluid.defaults("gpii.testem.base", { | |||
} | |||
}, | |||
cwd: "@expand:fluid.module.resolvePath({that}.options.cwd)", | |||
user_data_dir: "@expand:gpii.testem.resolveFluidModulePathSafely({that}.options.testemDir)", | |||
//user_data_dir: "@expand:gpii.testem.resolveFluidModulePathSafely({that}.options.testemDir)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray comments here, and on priority: first later on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that, fixed.
CI job passed: https://ci.gpii.net/job/gpii-testem-tests/11/ |
On my bare Windows machine, I get a test hang like the one reported above, only it is indefinite -
Shortly before the hang I see a window briefly open and close. I've updated to the latest Chromedriver and Chrome - any suggestions for what I can try now? |
@amb26, I have seen similar stuff in other projects, it may be that there are issues with recent "headless" chrome versions. Can you try skipping headless chrome and see if that avoids the hang? You can just add "Headless Chrome" to the other browsers that are skipped |
CI job failed: https://ci.gpii.net/job/gpii-testem-tests/12/ |
The last CI failure was a failure in provisioning the VM, and the lack of npm caused the linting stage to fail as well. Ok to test. |
CI job failed: https://ci.gpii.net/job/gpii-testem-tests/13/ |
Provisioning keeps failing because the chocolatey servers are down for maintenance (here's their status page). Will try again later. |
Chocolatey is back. Ok to test. |
CI job passed: https://ci.gpii.net/job/gpii-testem-tests/14/ |
…th the asyncTest conversion and the instrumentation disabled.
CI job passed: https://ci.gpii.net/job/gpii-testem-tests/15/ |
…tart` to use `jqUnit.asyncTest` instead.
CI job failed: https://ci.gpii.net/job/gpii-testem-tests/16/ |
I think the last build was left over from the previous commit. The build to test the test reordering is running now. |
CI job failed: https://ci.gpii.net/job/gpii-testem-tests/17/ |
Ok to test. |
CI job passed: https://ci.gpii.net/job/gpii-testem-tests/18/ |
Finally past the rollup doldrums thanks to the new version of gpii-webdriver. Let's run a couple more passes to confirm that we don't have some other lingering instability. Ok to test. |
CI job passed: https://ci.gpii.net/job/gpii-testem-tests/19/ |
I have cut the 2.1.10 release and updated the forward-facing version in master. There are still known issues with Windows and (non headless) Firefox, check out GPII-4145 for updates and workarounds. |
See GPII-3457 for details.