Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

GPII-91: updating build script to run 'npm install' in addition to cloni... #19

Merged
merged 2 commits into from Mar 13, 2013

Conversation

Projects
None yet
2 participants
Member

yzen commented Mar 6, 2013

...ng universal.

@kaspermarkus kaspermarkus commented on an outdated diff Mar 12, 2013

@@ -10,9 +10,10 @@
# You may obtain a copy of the License at
# https://github.com/gpii/universal/LICENSE.txt
+currentDirName=${PWD##*/}
@kaspermarkus

kaspermarkus Mar 12, 2013

Owner

Hi Yura,
You can change this to:

currentDirName=pwd

That will save the full current path to the variable

@kaspermarkus

kaspermarkus Mar 12, 2013

Owner

crap - ok apparently we hit some reserved char .. trying escaped

currentDirName=pwd

@kaspermarkus kaspermarkus commented on an outdated diff Mar 12, 2013

@@ -32,6 +33,10 @@ else
echo "$universal does not exist"
echo "cloning universal"
git clone "$repoURL" "$universal"
+ cd $universal
+ npm install
+ cd ../../
@kaspermarkus

kaspermarkus Mar 12, 2013

Owner

This can be removed if you do the above change, as the command in line 39 will take you directory to the dir

Owner

kaspermarkus commented Mar 12, 2013

other than that, it works great and is ready to be merged.. and it's a pleasure to see the "61,195 deletions" in the universal pull request!

Owner

kaspermarkus commented Mar 13, 2013

Looks good!! Thanks Yura

@kaspermarkus kaspermarkus reopened this Mar 13, 2013

kaspermarkus added a commit that referenced this pull request Mar 13, 2013

Merge pull request #19 from yzen/GPII-91
GPII-91: updating build script to run 'npm install' in addition to cloning the universal repository. This is a required chance after GPII/universal#77

@kaspermarkus kaspermarkus merged commit e5f3583 into GPII:master Mar 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment