Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-2395: XRandR bridge should provide all posible screen resolutions #92

Open
wants to merge 12 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@klown
Copy link
Contributor

klown commented Apr 24, 2017

@javihernandez, @kaspermarkus Here are changes to the Linux/GNOME XRandR bridge to provide all possible screen resolutions when asked.

I went a little further than just modifying the node add-on and the bridge to provide this information. I also refactored the bridge into a fluid component. It was previously a set of namespaced functions -- a number of fluid.defaults() each with a grade of "fluid.function". Now those functions are invokers within a gpii.xrandr fluid component.

One issue, though: @javihernandez, I'm not clear what the gpii.xrandr.allSettings construct at line 93 is for. I couldn't see where it was actually used outside of the XRandR bridge. I kept it, and its use inside the bridge, but couldn't actually fit it into the new gpii.xrandr component.

Anyhow, let me know what you think.

GPII-2395: XRandR bridge should provide all posible screen resolutions
- Modified the node XRandR add-on to return the available screen
resolutions as an array of JSON objects, rather than strings.
- Refactored the XRandR bridge code into a fluid component.
- Updated the unit tests in light of the above.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 24, 2017

CI job passed.

GPII-2395: XRandR bridge provides all available screen resolutions
Modified "screen-resolution" payload to now contain:
- "current-resolution" (width and height)
- "available-resolution" (array of widths and heights).
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented May 2, 2017

CI job passed.

GPII-2395: XRandR bridge provides all available screen resolutions
Modified to be analagous to the Windows display settings handler.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented May 19, 2017

CI job passed.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 26, 2017

CI job passed.

GPII-2395: XRandR bridge provides all available screen resolutions.
Remvoed {that} parameter from get() and set() functions.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jul 5, 2017

CI job passed.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Aug 4, 2017

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

@gtirloni

This comment has been minimized.

Copy link
Contributor

gtirloni commented Aug 28, 2017

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Aug 28, 2017

CI job passed.

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Feb 12, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Feb 12, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Feb 14, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Feb 22, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Mar 12, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 12, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Apr 2, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 2, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Apr 5, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 5, 2018

klown added some commits Apr 26, 2018

GPII-2395: Merge branch 'GPII-2568' into GPII-2395
Includes updating to latest master branch.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.