Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-457: Adding better support for the cloud based flow manager , solutions registry and match maker. #171

Closed
wants to merge 7 commits into from

Conversation

yzen
Copy link
Member

@yzen yzen commented Dec 9, 2013

No description provided.

@colinbdclark
Copy link
Member

@michelled, @kaspermarkus, and @amb26, what's the status of this pull request? It looks like something we should review and merge into master before @avtar does our final pre-review deployment.

Conflicts:
	gpii/node_modules/flowManager/configs/base.json
	gpii/node_modules/flowManager/configs/cloudBased.json
	gpii/node_modules/flowManager/configs/development.json
	gpii/node_modules/flowManager/configs/production.json
	gpii/node_modules/preferencesServer/configs/base.json
@colinbdclark
Copy link
Member

@amb26 will review this issue, but needs to discuss it with @yzen before it can go in.

@@ -0,0 +1,12 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file appears to have been migrated from a .js form of the same views held in sgithens repository, as referenced in the JIRA. Could you add a text file in this directory explaining this relationship, and also explaining i) why the form of the view differs from the upstream version, ii) instructions for the integrating user in importing the views into CouchDB (or else scripts for this) and iii) an explanation of what our intended trajectory is for these files - are we intending to keep them in this JSON format or are we intending to adopt a framework to help with managing them?
Thanks

@colinbdclark
Copy link
Member

Based on a conversation between @yzen and @amb26 today, we have determined that this pull request is not a blocker for the review or pilots, and only needs to be included in the repository once we're ready to move to a full-fledged remote Solutions Registry service.

@kaspermarkus
Copy link
Member

@amb26 Is this pull request still relevant?

@kaspermarkus
Copy link
Member

bumping - @amb26 Is this pull request still relevant?

@amb26
Copy link
Member

amb26 commented Aug 12, 2015

I think the only thing unique in this branch is the gpii-solutions.json view definition, and given that i) the solutions registry format has changed a little anyway ii) this came with no scheme for loading it into a database in any case, iii) this is something that @the-t-in-rtf has sufficient expertise now to easily reproduce, we can close this request

@amb26 amb26 closed this Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants