Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-1939: Device Reporter reports screen resolutions #536

Open
wants to merge 25 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@klown
Copy link
Contributor

klown commented Aug 3, 2017

@kaspermarkus, @javihernandez Here are the changes to the Device Reporter to have it add all available screen resolutions to its payload. Note that there are associated pull requests in the windows and linux branches, for doing the OS specific work.

@amb, FYI: this code replaces the "gpii.platform.native" grade with a context aware version of the platform reporter, as discussed in the pull request for the Process Reporter

klown added some commits Aug 1, 2017

GPII-1939: Device Reporter includes screen resolution information
- modified the Platform Reporter to be context aware.
- modified the Platform Reporter to allow OS contexts to report
additional specific information, e.g., screen resolutions.
GPII-1939: Device Reporter reports additional OS specific information
Renmaed the function for getting the OS specific information and fixed
spelling.
@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Aug 3, 2017

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Aug 3, 2017

CI job passed.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Aug 22, 2017

CI job passed.

GPII-1939: Simplified context aware features
Also, merged upstream GPII master branch into GPII-1939.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Sep 11, 2017

@gtirloni

This comment has been minimized.

Copy link
Contributor

gtirloni commented Sep 11, 2017

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Sep 11, 2017

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Sep 13, 2017

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Oct 4, 2017

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Oct 4, 2017

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Oct 4, 2017

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Oct 13, 2017

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Nov 14, 2017

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Dec 5, 2017

@kaspermarkus

This comment has been minimized.

Copy link
Member

kaspermarkus commented Dec 13, 2017

This is still very relevant, but mothballed until we have an effectology that can be used to take this into account on matchmaking

@kaspermarkus kaspermarkus requested a review from javihernandez Dec 13, 2017

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Feb 12, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Feb 20, 2018

GPII-1939: Device Reporter reports all screen resolutions
Merge upstream master branch into GPII-1939.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 12, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Mar 12, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 12, 2018

GPII-1939: Device Reporter reports all screen resolutions
Merge upstream master branch into GPII-1939.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 19, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 2, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 4, 2018

@gtirloni

This comment has been minimized.

Copy link
Contributor

gtirloni commented Apr 4, 2018

test this please

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 4, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Apr 4, 2018

Thanks @gtirloni but something odd is going on with the git fetch instruction. I tried it locally, and it got stuck in exactly the same place at 95%. Will investigate.

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Apr 5, 2018

ok to test

@gtirloni

This comment has been minimized.

Copy link
Contributor

gtirloni commented Apr 5, 2018

Looks like we were able to clone the repository this time: https://ci.gpii.net/job/universal-tests/808/console

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 5, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 25, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Apr 25, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 25, 2018

GPII-1939: DeviceReporter/PlatformReporter reports available screen r…
…esolutions

Merged upstream master GPII branch 'gpii-master' into GPII-1939
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented May 17, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 1, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.