Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-2843: Fix the broken browser channel example #586

Open
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@cindyli
Copy link
Contributor

cindyli commented Feb 2, 2018

Use the GPII config that includes the local flow manager to support the browser channel example.

GPII-2843: Use the GPII config that includes the local flow manager t…
…o support the browser channel example.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Feb 2, 2018

@cindyli cindyli requested a review from amb26 Feb 2, 2018

@@ -82,7 +82,7 @@ The workflow between the client and server can be summarised as follows:
The client has been checked in to [../examples/browserChannelClient](../examples/browserChannelClient). To try it out, first
start the GPII in the CloudBased browserChannel test configuration from the root of universal with

node gpii.js gpii/configs gpii.config.cloudBased.production
node gpii.js gpii/configs gpii.config.development.all.local

This comment has been minimized.

@amb26

amb26 Feb 2, 2018

Member

Actually it will be more helpful to direct the user to one of our mock configurations like https://github.com/GPII/universal/blob/master/gpii/configs/mocks/gpii.config.development.all.local.mock.windows.json5 which will allow them to see the results of a wider range of preference sets

@cindyli

This comment has been minimized.

Copy link
Contributor Author

cindyli commented Feb 2, 2018

I've made the change. Ready for another look, @amb26.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Feb 2, 2018

@cindyli

This comment has been minimized.

Copy link
Contributor Author

cindyli commented Mar 1, 2018

@amb26, now the initial user settings are set and returned at connectionSucceeded. The changes include:

  1. This example cannot use mock windows config file because the mock setImpl() does not set payload to the proper model path at model.settings;
  2. Using gpii.config.development.all.local config reads solution registry from darwin.json, which requires to add net.gpii.uioPlus solution into this JSON file.

This pull request is ready to be reviewed.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 1, 2018

@cindyli

This comment has been minimized.

Copy link
Contributor Author

cindyli commented Mar 1, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 1, 2018

GPII-2843: Switch to use "wget" from "curl" at building cloud based d…
…ocker container to find out if it helps to work around the couchdb connection failure.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 1, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 1, 2018

@gtirloni

This comment has been minimized.

Copy link
Contributor

gtirloni commented Jun 1, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 1, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.