Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-2429: Updated solutions registry with character spacing transformation #598

Merged
merged 4 commits into from Apr 5, 2018

Conversation

Projects
None yet
3 participants
@jobara
Copy link
Contributor

commented Mar 16, 2018

Updated the solutions registry entry for Character Spacing. It will do a linear scale to change the value range from start at 0 to starting at 1. The tests and test data were also updated.

https://issues.gpii.net/browse/GPII-2429

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 16, 2018

Could one of the admins verify that these changes are reasonable to test? If so, please reply with "ok to test".

@javihernandez

This comment has been minimized.

Copy link
Member

commented Mar 16, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 16, 2018

@javihernandez

This comment has been minimized.

Copy link
Member

commented Mar 30, 2018

Very neat, thanks!
Let's wait until you have a chance to take a look at this so I can test the two sides at the same time.

@javihernandez

This comment has been minimized.

Copy link
Member

commented Apr 4, 2018

I finally tested this one and worked like a charm, thanks @jobara!
In order for us to merge it, can you update it with current master and resolve the conflicts?

@jobara

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2018

@javihernandez I've updated from master and addressed the merged conflicts. Ready for more review.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2018

@jobara

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2018

@javihernandez the recent CI failure seems related to cloning. It looks similar to this issue https://issues.jenkins-ci.org/browse/JENKINS-36269?focusedCommentId=262656&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-262656 I wonder if it just needs to be re-run due to some network issues during the previous attempt?

@javihernandez

This comment has been minimized.

Copy link
Member

commented Apr 5, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Apr 5, 2018

@javihernandez javihernandez merged commit 36a77d7 into GPII:master Apr 5, 2018

1 check passed

default Build finished.
Details

@jobara jobara deleted the jobara:GPII-2429 branch Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.