Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-2578: Case-insensitive process matching for Windows. #600

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@stegru
Copy link
Member

stegru commented Mar 20, 2018

Process names are case-insensitive on Windows.

Goes with GPII/windows#169

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 20, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 20, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 26, 2018

@klown

klown approved these changes Mar 27, 2018

Copy link
Contributor

klown left a comment

Looks good to me.

return fluid.accumulate(procArray, function (aProcInfo, matchingProcs) {
if (aProcInfo.command === commandName) {
var match = aProcInfo.command === commandName ||

This comment has been minimized.

@klown

klown Mar 27, 2018

Contributor

Very succinct. Pay no attention to my comment on the other pull request about context awareness. This is the way to do it via a configurable option.

@gtirloni

This comment has been minimized.

Copy link
Contributor

gtirloni commented Jun 1, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 1, 2018

@stegru

This comment has been minimized.

Copy link
Member Author

stegru commented Jun 26, 2018

closing: merged into #534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.