Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3120: Improve grade inheritance of the PlatformReporter #618

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@klown
Copy link
Contributor

klown commented Jun 18, 2018

Replace the PlatformReporter's gpii.platform.native grade with infusion's context awareness. That is, implement the OS specific (native) functionality via a grade that capitalizes on a windows context, or linux context, or testing context, etc.

This pull against universal provides the basis for the switch to context awareness: one of the grade names for the PlatformReporter is "fluid.contextAware". The actual OS specific implementation is done in, for example, the Windows PlatformReporter that implements the "gpii.platformReporter.windows" context. Windows and Linux pull requests forthcoming.

klown added some commits Aug 1, 2017

GPII-3120: Modified PlatformReporter to use context awareness
Cherry-picked from bbd5037:

GPII-1939: Device Reporter includes screen resolution information

- modified the Platform Reporter to be context aware.
- modified the Platform Reporter to allow OS contexts to report
additional specific information, e.g., screen resolutions.
GPII-3120: Modified PlatformReporter to use context awareness
Cherry-picked from 8026442:

GPII-1939: Device Reporter reports additional OS specific information

Renmaed the function for getting the OS specific information and fixed
spelling.
GPII-3120: Added context awareness to the PlatformReporter
Cherry picked from 569642d:

GPII-1939:  Fixed lint error.
GPII-3120: Using context awareness to implement the PlatformReporter
Cherry picked from fcdec05:

GPII-1939:  Simplified context aware features

Also, merged upstream GPII master branch into GPII-1939.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 18, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Jun 20, 2018

@amb26
A long time ago in another life, you suggested that the PlatformReporter sub-component of the DeviceReporter should be abstract and use context awareness instead of a gpii.platform.native grade.

I made the changes to do that as part of GPII-1939, but, here, carved out the relevant code. That is, this pull isolates the switch to context awareness for the PlatformReporter.

CC @javihernandez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.