Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3319: Onboarding word space pref #666

Merged
merged 4 commits into from Oct 5, 2018

Conversation

Projects
None yet
4 participants
@jobara
Copy link
Contributor

commented Sep 20, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 20, 2018

Could one of the admins verify that these changes are reasonable to test? If so, please reply with "ok to test".

@javihernandez

This comment has been minimized.

Copy link
Member

commented Sep 20, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 20, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2018

@jobara

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2018

@amb26 could you please take a look at this PR as well. It includes the onboarding for the wordSpace preference. I've updated this with master so it includes the schema values now. Also I've fixed up some of the schema values. I found that the font size was incorrect and that some of the others have been changed in UIO+ recently.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 4, 2018

@amb26 amb26 merged commit d0d7dab into GPII:master Oct 5, 2018

1 check passed

default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.