Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3529: Report NoConnection user error when no cloud connection. #709

Merged
merged 3 commits into from Nov 19, 2018

Conversation

Projects
None yet
3 participants
@cindyli
Copy link
Contributor

cindyli commented Nov 13, 2018

No description provided.

@cindyli cindyli requested a review from amb26 Nov 13, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Nov 13, 2018

@@ -97,7 +97,15 @@ gpii.lifecycleManager.userLogonRequest.handleSuccessRequest = function (that, pa
gpii.lifecycleManager.userLogonRequest.handleFailedRequest = function (that, userErrorEvent, err) {
fluid.log("UserLogonRequest fails with the error: ", err);

if (!err.ignoreUserErrors) {
var connectionErrCode = ["ECONNREFUSED", "ETIMEDOUT", "ECONNRESET"];

This comment has been minimized.

Copy link
@amb26

amb26 Nov 13, 2018

Member

Put these in a public constant, together with a public checking function

This comment has been minimized.

Copy link
@cindyli

cindyli Nov 13, 2018

Author Contributor

@amb26, the ways in my mind in terms of where to put these public constants and public utility functions share by multiple GPII modules:

  1. within "flowManager" module such as flowManager/src/Utility.js;
  2. create a separae GPII module "gpii-utility" with Utility.js in its src/ directory.

Either way, Utility.js will be required by various GPII modules when it's needed. In this fix, these modules are "flowManager" and "lifecycleManager".

Which way would you prefer or do you have other ideas? Thanks.

This comment has been minimized.

Copy link
@amb26

amb26 Nov 14, 2018

Member

I suggest putting this constant and function in the gpii.userErrors namespace and module

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Nov 14, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Nov 14, 2018

@cindyli

This comment has been minimized.

Copy link
Contributor Author

cindyli commented Nov 14, 2018

Failed at "universal-create-vm" step. ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Nov 14, 2018

@cindyli

This comment has been minimized.

Copy link
Contributor Author

cindyli commented Nov 14, 2018

@amb26, review comments have been addressed and this pull request is ready for another look. Thanks.

@amb26 amb26 merged commit 99bee58 into GPII:master Nov 19, 2018

1 check passed

default Build finished.
Details

@cindyli cindyli deleted the cindyli:GPII-3529 branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.