Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3584: Improve the context manager logging information #719

Merged
merged 6 commits into from Jan 31, 2019

Conversation

Projects
None yet
3 participants
@cindyli
Copy link
Contributor

commented Dec 11, 2018

No description provided.

@cindyli cindyli requested a review from amb26 Dec 11, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Dec 11, 2018

// find and update context:
that.updateActiveContextName(fullPayload, forceContextName);

if (oldActiveContext === fullPayload.activeContextName) {
fluid.log(fluid.logLevel.TRACE, "contextManager: Same context as before (" + oldActiveContext + ") so doing nothing");
return;
}
fluid.log("contextManager: New active contexts: " + fullPayload.activeContextName);
fluid.log("contextManager: Apply a context change from the old context \"", oldActiveContext, "\" to a new active context \"" + fullPayload.activeContextName, "\" for the GPII key: ", activeGpiiKeys[0]);

This comment has been minimized.

Copy link
@amb26

amb26 Dec 12, 2018

Member

The present tense wording of these messages does sound a little odd.
How about, "Context changed from old context " .... " to new active context" ....

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Dec 12, 2018

@cindyli

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2018

@amb26, this pull request is ready for another look. Thanks.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Jan 16, 2019

@amb26 amb26 merged commit dfebab4 into GPII:master Jan 31, 2019

1 check passed

default Build finished.
Details
@cindyli

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2019

Merged at 7eb9cba

@cindyli cindyli deleted the cindyli:GPII-3584 branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.