Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3747: Replace /device http endpoint with an internal function call #752

Merged
merged 11 commits into from May 23, 2019

Conversation

Projects
None yet
3 participants
@cindyli
Copy link
Contributor

commented Mar 7, 2019

No description provided.

@cindyli cindyli requested a review from amb26 Mar 7, 2019

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 7, 2019

@cindyli

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

21:35:25.185: jq: FAIL: Module "gpii.tests.acceptance.suppressHttpEndpoints.config tests" Test name "/login endpoint has been removed when the suppressHttpEndpoints flag is turned on" - Message: Assertion failure (see console.log for expanded message): Error: resolving promise ,[object Object], which has already received "resolve"

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 7, 2019

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 7, 2019

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 8, 2019

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented May 15, 2019

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented May 16, 2019

@@ -0,0 +1,111 @@
/*!

This comment has been minimized.

Copy link
@amb26

amb26 May 22, 2019

Member

We should put "Tests" into the name of this file so it doesn't cause confusion in people's IDEs ....


var devicePromise = deviceReporter.get();
devicePromise.then(function (deviceData) {
fluid.log("Private Match Maker, doMatch - received device data: ", deviceData);

This comment has been minimized.

Copy link
@amb26

amb26 May 22, 2019

Member

Normalise this to "MatchMaker" as seen elsewhere

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

@cindyli

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

@amb26, all comments have been addressed. This pull request is ready for another look. Thanks.

@amb26 amb26 merged commit 37264a5 into GPII:master May 23, 2019

1 check passed

default Build finished.
Details
@cindyli

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

Merged at ce4aa5d

@cindyli cindyli deleted the cindyli:GPII-3747 branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.