Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3784: Transformer does not filter out settings handlers that match any interim setting path #755

Merged
merged 3 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@cindyli
Copy link
Contributor

commented Mar 9, 2019

No description provided.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 9, 2019

@cindyli

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2019

CI is slow at running tests and hits the debounce rule for /proximityTriggered:

00:58:32.993: Test case listener has not responded after 5000ms - at sequence pos 13 of 16 sequence element {
"event": "{proximityTriggeredRequest3}.events.onComplete",
"listener": "kettle.test.assertErrorResponse",
"args": {
"message": "Received 429 error due to debounce rules",
"errorTexts": "Proximity trigger ignored due to bounce rules",
"statusCode": 429,
"string": "{arguments}.0",
"request": "{proximityTriggeredRequest3}"
}
} of fixture Testing proximityTriggered logout with debounce

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 9, 2019

@cindyli cindyli requested a review from amb26 Mar 9, 2019

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented May 14, 2019

@cindyli

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@amb26, the transformer functions have been adjusted based on our discussion from yesterday. This pull request is ready for another look. Thanks.

@amb26 amb26 merged commit 908bdbb into GPII:master May 15, 2019

1 check passed

default Build finished.
Details
@cindyli

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Merged at e73581a

@cindyli cindyli deleted the cindyli:GPII-3784 branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.