GPII-91: Removed node_modules. Updated package.json so we do not need to keep track of udpates any more.

[yzen]

No description provided.

[amb26]

Typo here

[amb26]

Logically, this (gpii global name) should go inside the closure - just in case we ever plan to apply versioning to the gpii namespace as well. Currently the "logical or trick" only works at global scope, but we hope to replace this back with "require" some day

[amb26]

Hi Yura - this pull request represents a lot of good work! Thanks also for the readable and helpful readme file. The system almost seems to work - all test cases look good - unfortunately the system itself fails. Attempting logon with this URL: http://localhost:8081/user/sammy/login
produces a particularly incomprehensible returned JSON structure:

{
"isError": true,
"message": "demultiplexValue requires a list or hash of options at path named "options", supplied function deliverer(value) {\n target[name] = value;\n }[object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object][object Object]"
}

The system then crashes due to a TypeError - this should be impossible given our efforts to improve robustness of the system - but unfortunately this is a hard failure rather than a fluid.fail. We need to adopt a production-oriented approach to these kinds of failures too. The stack trace is as follows:

00:58:17.292: Firing event onMatch of component with typename gpii.requests.request.handler and id 5usx3f4b-155 to list of 1 liste
ners
00:58:17.295: Firing event onError of component with typename gpii.requests.request and id 5usx3f4b-148 to list of 1 listeners

E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\ModelTransformations.js:256
return expandSpec.options[testVal];
^
TypeError: Cannot read property 'undefined' of undefined
at deref (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\ModelTransformations.js:
256:42)
at fluid.model.transform.valueMapper (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\ModelTransformations.js:259:23)
at Object.fluid.expandExpander (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1532:29)
at Object.fluid.expandSource (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1607:30)
at Object.fluid.makeExpandStrategy.strategy (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1656:26)
at fluid.fetchExpandChildren (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1561:25)
at Object.fluid.each (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\Fluid.js:337
:17)
at Object.fluid.fetchExpandChildren (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1556:15)
at fluid.makeExpandStrategy.recurse (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1634:26)
at Object.fluid.expandSource (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1623:13)
at Object.fluid.makeExpandStrategy.strategy (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1656:26)
at fluid.fetchExpandChildren (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1561:25)
at Object.fluid.each (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\Fluid.js:333
:17)
at Object.fluid.fetchExpandChildren (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1556:15)
at Object.fluid.makeExpandOptions.options.initter (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1682:40)
at Object.fluid.expand (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1700:17)
at Object.gpii.lifecycleManager.resolver.finalInit.that.resolve (E:\Source\gits\gpii\node_modules\universal\gpii\node_modules\lifecycleManager\src\LifecycleManager.js:69:26)
at Object.gpii.lifecycleManager.preInit.that.start.sessionState.localResolver (E:\Source\gits\gpii\node_modules\universal\gpii\node_modules\lifecycleManager\src\LifecycleManager.js:221:46)
at Function.gpii.lifecycleManager.executeActions (E:\Source\gits\gpii\node_modules\universal\gpii\node_modules\lifecycleManager\src\LifecycleManager.js:181:49)
at Object.1 (E:\Source\gits\gpii\node_modules\universal\gpii\node_modules\lifecycleManager\src\LifecycleManager.js:229:63)
at transformInternal (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\Fluid.js:293
:34)
at Object.fluid.transform (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\Fluid.js:314:17)
at Object.gpii.lifecycleManager.preInit.that.start (E:\Source\gits\gpii\node_modules\universal\gpii\node_modules\lifecycleManager\src\LifecycleManager.js:226:44)
at gpii.requests.request.handler.userLoginPreInit.that.onMatchHandler (E:\Source\gits\gpii\node_modules\universal\gpii\node_modules\flowManager\src\UserLogin.js:46:35)
at fireToListeners (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\Fluid.js:879:6
8)
at Object.fluid.makeEventFirer.that.fire (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\Fluid.js:954:24)
at gpii.requests.request.handler.userLoginPreInit.that.onReadyToMatchHandler (E:\Source\gits\gpii\node_modules\universal\gpii\node_modules\flowManager\src\UserLogin.js:42:37)
at gpii.wrapCallback (E:\Source\gits\gpii\node_modules\universal\gpii\node_modules\gpiiFramework\request.js:226:33)
at fluid.withEnvironment (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1407:20)
at Object.fluid.tryCatch (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\Fluid.js:138:24)
at Object.fluid.withEnvironment (E:\Source\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\framework\core\js\FluidIoC.js:1402:22)
at gpii.wrapCallback (E:\Source\gits\gpii\node_modules\universal\gpii\node_modules\gpiiFramework\request.js:223:26)
at gpii.dataSource.URL.handle.callback (E:\Source\gits\gpii\node_modules\universal\gpii\node_modules\gpiiFramework\dataSource.js:329:13)
at IncomingMessage.gpii.dataSource.URL.handle.url.req.on.options.fireOnError.isError (E:\Source\gits\gpii\node_modules\universal
\gpii\node_modules\gpiiFramework\dataSource.js:358:17)
at IncomingMessage.EventEmitter.emit (events.js:115:20)
at IncomingMessage._emitEnd (http.js:366:10)
at HTTPParser.parserOnMessageComplete as onMessageComplete
at Socket.socketOnData as ondata
at TCP.onread (net.js:402:27)

This request works fine with current GPII master. It appears that this pull request is still over-broad and includes a lot of the XMLSettingsHandler work we looked at in San Diego - is this really complete and ready to go? It appears that the changes to the Model Transformation system are still not correct. If this needs further work do thing about issuing a yet smaller pull request which just includes your node_modules work which all looks good.

Cheers,
A