Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-2404: Changed windows' display settings handler to retrieve all screen resolutions #121

Open
wants to merge 24 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@klown
Copy link
Contributor

klown commented May 8, 2017

@kaspermarkus, @javihernandez

The modifiications to the window settings handler analogous to the linux pull request.

GPII-2404: Windows display settings handler should report available s…
…creen resolutions

- Modified the display settings handler to get both the current and all available
screen resolutions in one JSON object.
- Refactored the handler into a fluid component.
- Updated the unit tests in light of the above.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented May 8, 2017

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

GPII-2404: Windows display settings handler should report available s…
…creen resolutions

Reverted getScreenResolution() to return an object with just width and height, but
modified getImpl() to add a "screen-resolution" property.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented May 18, 2017

CI job passed.

GPII-2404: Windows display settings handler reports available screen …
…resolutions

Better way to set current screen resolution return value.  Also, cleaned up some
comments.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented May 19, 2017

CI job passed.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 26, 2017

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Jun 26, 2017

@amatas, according to the console log, the VM creation timed out. No tests were run. Any idea why?

@amatas

This comment has been minimized.

Copy link

amatas commented Jun 27, 2017

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 27, 2017

CI job passed.

@amatas

This comment has been minimized.

Copy link

amatas commented Jun 27, 2017

@klown sorry but seems that the creation of the VM took so much time to install some things that the Jenkins aborted the task. Perhaps it was because the host was very busy with other tasks. Now the tests passed.

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Jun 27, 2017

@amatas no problem -- it's not your fault. Thanks for re-running it!

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jul 5, 2017

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Jul 12, 2017

@amatas Tapping your shoulder...

@amatas

This comment has been minimized.

Copy link

amatas commented Jul 12, 2017

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jul 12, 2017

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Jul 12, 2017

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jul 12, 2017

CI job passed.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Aug 4, 2017

CI job passed.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Aug 24, 2017

CI job passed.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Aug 24, 2017

CI job passed.

GPII-2404: Display settings handler returns all screen resolutions.
Modifed the "getAllScreenResolutions" to drop the "dmPels" prefix.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Aug 25, 2017

CI job passed.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Feb 17, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Feb 20, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Feb 20, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Feb 20, 2018

GPII-2404: Display settings handler reports all screen resoltuions.
Merge upstream master GPII windows branch into GPII-2404.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 12, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Mar 12, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Mar 12, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 2, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Apr 5, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 5, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 25, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Apr 25, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 25, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented May 17, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Jun 4, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 4, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Jun 5, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 5, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Jun 6, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 6, 2018

GPII-2404: Merge pull request #177 from stegru/GPII-3066
Stop acceptance tests crashing.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 7, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.