Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-1939, GPII-2404 - Device Reporter to report screen resolutions #134

Open
wants to merge 50 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@klown
Copy link
Contributor

klown commented Aug 4, 2017

Windows specific code for Device Reporter to report screen resolutions.

klown added some commits May 5, 2017

GPII-2404: Windows display settings handler should report available s…
…creen resolutions

- Modified the display settings handler to get both the current and all available
screen resolutions in one JSON object.
- Refactored the handler into a fluid component.
- Updated the unit tests in light of the above.
GPII-2404: Windows display settings handler should report available s…
…creen resolutions

Reverted getScreenResolution() to return an object with just width and height, but
modified getImpl() to add a "screen-resolution" property.
GPII-2404: Windows display settings handler reports available screen …
…resolutions

Better way to set current screen resolution return value.  Also, cleaned up some
comments.
GPII-1939: New Platform Reporter reports screen resolutions
Added machinery for providing a Linux/GNOME Platform Reporter that
uses the Windows display settings handler to report all screen resolutions.

Note:  includes code from pull request for GPII-2404, "Windows display
settings handler should report all available screen resolutions".
GPII-1939: Device Reporter reports screen resolutions
Fixed bug so that GPII finds the Windows context platform reporter.
@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Aug 4, 2017

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Aug 4, 2017

CI job passed.

@klown klown changed the title GPII-2939, GPII-2404 GPII-1939, GPII-2404 Aug 24, 2017

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Aug 24, 2017

CI job passed.

klown added some commits Aug 24, 2017

GPII-2404: DeviceReporter reports available screen resolutions
Modified PlatformReporter to remove the "dmPels" prefix on width
and height as returned by the display settings handler.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Aug 24, 2017

CI job passed.

klown added some commits Aug 25, 2017

GPII-2404: Display settings handler returns all screen resolutions.
Modifed the "getAllScreenResolutions" to drop the "dmPels" prefix.
GPII-2404: DeviceReporter reports available screen resolutions
- Merge branch 'GPII-2404' into GPII-1939_GPII-2404
- Since the DisplaySettingsHandler removes the "dmPels" prefix when
returning the available screen resolutions, modified the PlatformReporter
to simply relay the information as given.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Aug 25, 2017

CI job passed.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Sep 11, 2017

CI job passed.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 2, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 5, 2018

GPII-1939: Reference applicable version of universal.
Modified to reference the version of universal just prior to
incorporating Kasper's GPII-1230 code, which introduced functionality
not yet implemented in the windows repository.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 6, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Apr 6, 2018

ok to test

1 similar comment
@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Apr 6, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 6, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 6, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Apr 6, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 6, 2018

klown added some commits Apr 25, 2018

GPII-1939: Merged in latest GPII-2404 branch
Includes latest changes from GPII master branch.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Apr 25, 2018

klown added some commits May 17, 2018

GPII-1939: DeviceReporter/PlatformReporter reports available screen r…
…esolutions

Mergeed upstream master GPII branch, including changes from GPII-2404.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented May 17, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Jun 4, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 4, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Jun 5, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 5, 2018

@klown

This comment has been minimized.

Copy link
Contributor Author

klown commented Jun 6, 2018

ok to test

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 6, 2018

klown added some commits Jun 7, 2018

GPII-2404: Merge pull request #177 from stegru/GPII-3066
Stop acceptance tests crashing.
@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 7, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

gpii-bot commented Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.