Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot see toggles in settings menu when in dark mode #205

Open
nickywright opened this issue Nov 2, 2022 · 2 comments
Open

Cannot see toggles in settings menu when in dark mode #205

nickywright opened this issue Nov 2, 2022 · 2 comments
Assignees
Labels
bug Something isn't working low Low priority

Comments

@nickywright
Copy link
Contributor

In dark mode, it is really hard to see the toggle (options on the right) and that you can change them for the Settings. Can this be adjusted slightly?
It's much easier to tell you can interact with them in light mode

@nickywright nickywright added the bug Something isn't working label Nov 2, 2022
@michaelchin
Copy link
Contributor

Do you mean these guys in the screenshot below?

Screen Shot 2022-11-03 at 12 36 18 pm

@matthew-merkas matthew-merkas self-assigned this Nov 4, 2022
@matthew-merkas
Copy link
Contributor

In #211, I've improved the contrast of the dark theme colour palette. Google's Material Design 2 guidelines follow WCAG's AA standard for contrast (at least 4.5:1). We were already meeting that with the old colours, but the new lower-contrast colours also meet the AAA "enhanced" contrast (at least 7.1:1).

Old colours:
Screenshot 2022-11-05 at 00 23 29

New colours:
Screenshot 2022-11-05 at 00 22 23

Let me know if this is what you meant/if this solves the issue

@michaelchin michaelchin added the low Low priority label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low Low priority
Projects
None yet
Development

No branches or pull requests

3 participants