Yiyan toolmenu #105
Merged
Yiyan toolmenu #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. fix bug that change raster map will cover vector data layer
# Conflicts: # src/components/RasterMenu.tsx
2. complete vector data dynamic update function, so vector data list will uncheck all layers and automatically update to corresponding list when we change the raster map.
# Conflicts: # src/components/VectorDataLayerMenu.tsx
create button in tool menu to switch graph
# Conflicts: # src/components/GraphPanel.tsx
"Fill the horizontal space as much as possible, only use vertical space as last resort." abstract tool menu component
|
@yiyanw did you create "yiyan_toolmenu" branch from your other dev branch? I saw many old commits in this PR. Usually we create new branch from the "main" branch to avoid old commits get into PR. |
Yes, I double check the branch name and I realize I did not create new branch for it. I will create the new branch for future qull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement new version of tool menu:
"Fill the horizontal space as much as possible, only use vertical space as last resort."
abstract tool menu component
#103
please do not close the issue