Geoffrey Roguelon GRoguelon

GRoguelon commented on pull request ruby/www.ruby-lang.org#1049
@GRoguelon

Done! Thanks.

@GRoguelon
  • d444774
    Translate the news about CVE-2015-1855 in FR.
@GRoguelon
Translate the news about CVE-2015-1855 in FR.
1 commit with 226 additions and 0 deletions
GRoguelon deleted branch CVE-2015-1855_FR at GRoguelon/www.ruby-lang.org
@GRoguelon
  • 61ae149
    Translate the news about CVE-2015-1855 in FR.
@GRoguelon
@GRoguelon
Translate 2.2.1 is released (fr).
1 commit with 50 additions and 0 deletions
GRoguelon deleted branch last_5_fr_news at GRoguelon/www.ruby-lang.org
GRoguelon deleted branch rexml_ssl_tls at GRoguelon/www.ruby-lang.org
GRoguelon deleted branch tropical_ruby_2015 at GRoguelon/www.ruby-lang.org
GRoguelon deleted branch update_ruby_22_news at GRoguelon/www.ruby-lang.org
GRoguelon deleted branch update_ruby_220_fr_news at GRoguelon/www.ruby-lang.org
@GRoguelon
GRoguelon commented on pull request rails/rails#18816
@GRoguelon

What I will say may be stupid but when we use uuid PK, the order is meaningless. Why don't we add a class variable in the model allowing the develo…

GRoguelon commented on pull request rails/rails#18816
@GRoguelon

Hi @sgrif I updated the code, any feedback from @metaskills? Thanks.

@GRoguelon
GRoguelon commented on pull request rails/rails#18816
@GRoguelon

Understood, I will update my pull request with this solution. Thanks @sgrif

GRoguelon commented on pull request rails/rails#18816
@GRoguelon

I though to this solution but it will load the all collection if none limit_valueis specified. With your code: Car.last #=> Car Load (0.3ms) SELEC…

GRoguelon commented on pull request rails/rails#18816
@GRoguelon

Something like that: def find_last if loaded? @records.last else @last ||= if limit_value to_a.last elsif !primary_key limit(1).to_a.last else reve…

GRoguelon commented on pull request rails/rails#18816
@GRoguelon

Something like that: def find_last if loaded? @records.last else @last ||= if limit_value to_a.last elsif !primary_key limit(1).to_a.last else reve…

GRoguelon commented on pull request rails/rails#18816
@GRoguelon

Hi @rafaelfranca, Do you have in mind something like that?

@GRoguelon
GRoguelon commented on pull request rails/rails#18816
@GRoguelon

In reading the code, I saw the lastmethod checks already if the primary key is present thus I deduced the last author wanted to handle this case. C…

GRoguelon commented on pull request rails/rails#18816
@GRoguelon

This test is the inverse of the test_last test, for me it's a duplication because if one test fails the other will fail too.

GRoguelon commented on pull request rails/rails#18816
@GRoguelon

I looked for in all test models, in the schema.rb and I didn't find none model without primary key.