2024-03-30 | MAIN --> PROD | DEV (f80b140) --> STAGING

[jadudm]

This is an auto-generated pull request to merge main into prod for a staging release on 2024-03-30 with the last commit being merged as f80b140

[github-actions]

Terraform plan for staging

No changes. Your infrastructure matches the configuration.

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.staging.module.cg-logshipper.module.s3-logshipper-storage.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/staging.cg-logshipper.s3-logshipper-storage/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 3 more similar warnings elsewhere)

✅ Plan applied in Deploy to Staging Environment #186

[github-actions]

Terraform plan for production

Plan: 0 to add, 1 to change, 0 to destroy.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place

Terraform will perform the following actions:

  # module.production.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
!~  resource "cloudfoundry_app" "clamav_api" {
        id                              = "5d0afa4f-527b-472a-8671-79a60335417f"
!~      instances                       = 16 -> 8
        name                            = "fac-av-production"
#        (15 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on /tmp/terraform-data-dir/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 4 more similar warnings elsewhere)

📝 Plan generated in Pull Request Checks #2707

[github-actions]

File	Coverage		Missing
All files	88%	✅
api/serializers.py	88%	✅	177-178 183 188
api/test_views.py	95%	✅	103
api/uei.py	88%	✅	87 118-119 163 167-168
api/views.py	98%	✅	198-199 337-338
audit/forms.py	60%	❌	31-38 108-115
audit/intake_to_dissemination.py	88%	✅	57-62 264 308-316
audit/mixins.py	96%	✅	27
audit/test_commands.py	91%	✅
audit/test_intakelib.py	88%	✅	154-158
audit/test_manage_submission_access_view.py	98%	✅	15 19
audit/test_mixins.py	90%	✅	159-160 164-166 254-255 259-261
audit/test_validators.py	95%	✅	439 443 611-612 851 858 865 872 1107-1108 1139-1140 1165-1170
audit/test_views.py	98%	✅	132
audit/test_workbooks_should_fail.py	88%	✅	58 87-88 92
audit/test_workbooks_should_pass.py	87%	✅	59 74-76
audit/utils.py	91%	✅	33-35 38
audit/validators.py	93%	✅	138 190 378-379 394-395 478-479 581-585 590-594 610-619
audit/cross_validation/additional_ueis.py	93%	✅	33
audit/cross_validation/check_award_ref_declaration.py	90%	✅
audit/cross_validation/check_award_reference_uniqueness.py	93%	✅
audit/cross_validation/check_certifying_contacts.py	87%	✅
audit/cross_validation/check_findings_count_consistency.py	91%	✅
audit/cross_validation/check_ref_number_in_cap.py	90%	✅
audit/cross_validation/check_ref_number_in_findings_text.py	90%	✅
audit/cross_validation/errors.py	78%	❌	30 69
audit/cross_validation/naming.py	93%	✅	197
audit/cross_validation/submission_progress_check.py	95%	✅	80
audit/cross_validation/tribal_data_sharing_consent.py	81%	❌	33 36 40
audit/cross_validation/validate_general_information.py	64%	❌	72 76-79 91 94
audit/fixtures/single_audit_checklist.py	55%	❌	146-183 229-238
audit/intakelib/exceptions.py	71%	❌	7-9 12
audit/intakelib/intermediate_representation.py	91%	✅	27-28 73 91 129 200-203 212-213 283-284
audit/intakelib/mapping_audit_findings.py	97%	✅	55
audit/intakelib/mapping_audit_findings_text.py	97%	✅	52
audit/intakelib/mapping_federal_awards.py	93%	✅	90
audit/intakelib/mapping_util.py	79%	❌	21 25 29 63 99 104-105 114-120 130 145 150
audit/intakelib/checks/check_all_unique_award_numbers.py	79%	❌	24
audit/intakelib/checks/check_cluster_names.py	75%	❌	20-25
audit/intakelib/checks/check_cluster_total.py	95%	✅	99
audit/intakelib/checks/check_has_all_the_named_ranges.py	95%	✅	66
audit/intakelib/checks/check_is_a_workbook.py	69%	❌	20
audit/intakelib/checks/check_loan_balance_entries.py	83%	❌	28
audit/intakelib/checks/check_look_for_empty_rows.py	91%	✅	18
audit/intakelib/checks/check_no_major_program_no_type.py	76%	❌	18 27
audit/intakelib/checks/check_no_repeat_findings.py	76%	❌	21 30
audit/intakelib/checks/check_other_cluster_names.py	81%	❌	23 33
audit/intakelib/checks/check_passthrough_name_when_no_direct.py	88%	✅	9 47
audit/intakelib/checks/check_sequential_award_numbers.py	82%	❌	25 35
audit/intakelib/checks/check_start_and_end_rows_of_all_columns_are_same.py	89%	✅	14
audit/intakelib/checks/check_state_cluster_names.py	81%	❌	23 33
audit/intakelib/checks/check_version_number.py	73%	❌	21 31-32
audit/intakelib/checks/runners.py	96%	✅	148
audit/intakelib/common/util.py	90%	✅	22 39
audit/intakelib/transforms/xform_rename_additional_notes_sheet.py	81%	❌	14
audit/management/commands/load_fixtures.py	46%	❌	39-45
audit/models/models.py	85%	✅	58 60 65 67 209 215 227 239-242 260 437 455-456 464 486 584-585 589 597 606 612
audit/views/audit_info_form_view.py	27%	❌	25-74 77-117 120-137
audit/views/manage_submission.py	86%	✅	73-80
audit/views/manage_submission_access.py	98%	✅	113-114
audit/views/pre_dissemination_download_view.py	78%	❌	15-16 21-22 29-39
audit/views/submission_progress_view.py	96%	✅	176-177
audit/views/tribal_data_consent.py	34%	❌	23-41 44-79
audit/views/unlock_after_certification.py	57%	❌	28-51 73-87
audit/views/upload_report_view.py	26%	❌	32-35 44 91-117 120-170 178-209
audit/views/views.py	53%	❌	74 81-100 123-124 198-199 220-230 259-260 271-272 274-278 320-333 336-350 355-368 385-391 396-416 443-447 452-481 524-528 533-553 580-584 589-618 661-665 670-682 685-695 700-712 745-759
census_historical_migration/change_record.py	96%	✅	30 34
census_historical_migration/test_federal_awards_xforms.py	99%	✅	208-209
census_historical_migration/sac_general_lib/audit_information.py	91%	✅	24 78
census_historical_migration/sac_general_lib/cognizant_oversight.py	68%	❌	11
census_historical_migration/sac_general_lib/general_information.py	91%	✅	150-151 159-160 204 275
census_historical_migration/sac_general_lib/sac_creator.py	90%	✅	34
census_historical_migration/sac_general_lib/utils.py	83%	❌	33 60-69
census_historical_migration/transforms/xform_retrieve_uei.py	67%	❌	10
census_historical_migration/workbooklib/additional_eins.py	84%	❌	58-60 67-77
census_historical_migration/workbooklib/additional_ueis.py	77%	❌	27-29 36-46
census_historical_migration/workbooklib/corrective_action_plan.py	81%	❌	40-42 73-89
census_historical_migration/workbooklib/excel_creation_utils.py	65%	❌	99 108-113 118-125 129-147 160-164 178-181
census_historical_migration/workbooklib/federal_awards.py	70%	❌	94-97 268 309-317 327-352 485-576
census_historical_migration/workbooklib/findings.py	27%	❌	40-45 91-111 116-136 149-151 158-179
census_historical_migration/workbooklib/findings_text.py	81%	❌	38-39 70-87
census_historical_migration/workbooklib/notes_to_sefa.py	55%	❌	34-38 101-102 104-105 107-108 135-141 149-157 165-167 172-189 196-232
config/error_handlers.py	94%	✅	22
config/test_settings.py	92%	✅	33-34 49-50
config/urls.py	72%	❌	88
dissemination/file_downloads.py	81%	❌	43-61 91-93
dissemination/forms.py	91%	✅	114 123 196
dissemination/search.py	60%	❌	97 104 106 109-117
dissemination/summary_reports.py	74%	❌	274 300-302 306-310 421 438 459 511-575 601 638-640 663-670
dissemination/test_search.py	91%	✅	44-59 346-347 452-469 481-505 517-542 550-566
dissemination/test_summary_reports.py	98%	✅
dissemination/views.py	76%	❌	130 136-138 154-218 261 291 293 326 377 379 381 459-464
dissemination/migrations/0002_general_fac_accepted_date.py	47%	❌	10-12
dissemination/searchlib/search_alns.py	37%	❌	44-58 78-110 115-177 184-187
dissemination/searchlib/search_direct_funding.py	86%	✅	21-22
dissemination/searchlib/search_findings.py	76%	❌	20-26 36 38 40
dissemination/searchlib/search_general.py	98%	✅
djangooidc/backends.py	78%	❌	32 57-63
djangooidc/exceptions.py	66%	❌	19 21 23 28
djangooidc/oidc.py	16%	❌	32-35 45-51 64-70 92-149 153-199 203-226 230-275 280-281 286
djangooidc/views.py	81%	❌	22 43 109-110 117
djangooidc/tests/common.py	97%	✅
report_submission/forms.py	92%	✅	35
report_submission/views.py	78%	❌	86 225 249-250 255-256 296-442 445-455
report_submission/templatetags/get_attr.py	76%	❌	8 11-14 18
support/admin.py	88%	✅	76 79 84 91-97 100-102
support/cog_over.py	91%	✅	30-33 93 145
support/test_admin_api.py	80%	❌	22 146-147 236-237 316-317
support/test_cog_over.py	98%	✅	134-135 224
support/management/commands/seed_cog_baseline.py	98%	✅	20-21
support/models/cog_over.py	89%	✅	103-104
tools/update_program_data.py	89%	✅	96
users/admin.py	99%	✅	27
users/auth.py	96%	✅	58-59
users/models.py	96%	✅	18 74-75
users/fixtures/user_fixtures.py	91%	✅

Minimum allowed coverage is 85%

Generated by 🐒 cobertura-action against f80b140