-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MH from developer list #3845
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danswick
approved these changes
May 15, 2024
Terraform plan for meta Plan: 0 to add, 4 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# module.environments["dev"].cloudfoundry_space_users.space_permissions will be updated in-place
!~ resource "cloudfoundry_space_users" "space_permissions" {
!~ developers = [
- "matt.henry@gsa.gov",
# (13 unchanged elements hidden)
]
id = "06525ba3-19c2-451b-96e9-ea4a9134e8b9"
# (4 unchanged attributes hidden)
}
# module.environments["preview"].cloudfoundry_space_users.space_permissions will be updated in-place
!~ resource "cloudfoundry_space_users" "space_permissions" {
!~ developers = [
- "matt.henry@gsa.gov",
# (13 unchanged elements hidden)
]
id = "c21cdcb1-b760-4f3e-968d-469819b448e9"
# (4 unchanged attributes hidden)
}
# module.environments["production"].cloudfoundry_space_users.space_permissions will be updated in-place
!~ resource "cloudfoundry_space_users" "space_permissions" {
!~ developers = [
- "matt.henry@gsa.gov",
# (13 unchanged elements hidden)
]
id = "5593dba8-7023-49a5-bdbe-e809fe23edf9"
# (4 unchanged attributes hidden)
}
# module.environments["staging"].cloudfoundry_space_users.space_permissions will be updated in-place
!~ resource "cloudfoundry_space_users" "space_permissions" {
!~ developers = [
- "matt.henry@gsa.gov",
# (13 unchanged elements hidden)
]
id = "7bbe587a-e8ee-4e8c-b32f-86d0b0f1b807"
# (4 unchanged attributes hidden)
}
Plan: 0 to add, 4 to change, 0 to destroy.
Warning: Argument is deprecated
with module.s3-backups.cloudfoundry_service_instance.bucket,
on /tmp/terraform-data-dir/modules/s3-backups/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
14: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases ✅ Plan applied in Deploy to Development and Management Environment #667 |
Terraform plan for dev Plan: 0 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# module.dev.module.https-proxy.cloudfoundry_app.egress_app will be updated in-place
!~ resource "cloudfoundry_app" "egress_app" {
id = "a6eb3870-2769-4aa9-a8f2-f1a31939f563"
name = "https-proxy"
!~ source_code_hash = "48b2f5eba8d1f35c0fbc2f90c2ec87cab180f5f19e7e34b16b9190fe5c5ca09a" -> "e246274fca627d48afccde010de949371f24b6c9974c48aa91044acd36654fa8"
# (21 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
Warning: Argument is deprecated
with module.dev.module.cg-logshipper.module.s3-logshipper-storage.cloudfoundry_service_instance.bucket,
on /tmp/terraform-data-dir/modules/dev.cg-logshipper.s3-logshipper-storage/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
14: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 4 more similar warnings elsewhere) ✅ Plan applied in Deploy to Development and Management Environment #667 |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 75f4225 |
tadhg-ohiggins
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist: submitters
main
into your branch shortly before creating the PR. (You should also be mergingmain
into your branch regularly during development.)git status | grep migrations
. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrations
to reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up
; then rundocker compose exec web /bin/bash -c "python manage.py test"
The larger the PR, the stricter we should be about these points.