Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image processing #2656

Merged
merged 6 commits into from May 20, 2020
Merged

Fix image processing #2656

merged 6 commits into from May 20, 2020

Conversation

saracope
Copy link
Contributor

@saracope saracope commented May 19, 2020

Summary

This PR implements the following changes:

  • remove the set-env task from gulpfile.js (was not working) and references to it in package.json
  • sets the node_env to production when running on federalist
  • add a check for the development environment before loading image tasks
  • adds a watch task to monitor the content/images/_inbox folder for changes; when a change is made (image added) it will kick of the img task to process and upload the image
  • add dist folder to the .gitignore file so we're not asked to commit any changes that get compiled there
  • update uswds.js and the browsers list that was breaking due to recent changes on uswds-gulp

Documentation has also been updated:
https://github.com/GSA/digitalgov.gov/wiki/Adding-Images

Testing
From your project repository, bring in the changes to test:
first be sure you have the lastest production build

  • git pull origin master
  • git fetch origin

then checkout this branch

  • git checkout -b sc_fix-gulp-img origin/sc_fix-gulp-img
    and merge it with master so you're testing the most up-to-date version
  • git merge master

and spin the platform up locally and test with images

  • run npm start
  • add a test image to the content/images/_inbox folder
  • verify that the img script ran and the appropriate files were created

@saracope saracope added the Dev: frontend ideas and issues related to the presentation layer of the site label May 19, 2020
@github-actions
Copy link

🔍 Preview in Federalist

@saracope saracope marked this pull request as draft May 19, 2020 17:22
@github-actions
Copy link

🔍 Preview in Federalist

@github-actions
Copy link

🔍 Preview in Federalist

@github-actions
Copy link

🔍 Preview in Federalist

@saracope saracope marked this pull request as ready for review May 20, 2020 02:27
@saracope saracope mentioned this pull request May 20, 2020
1 task
@ToniBonittoGSA ToniBonittoGSA merged commit 4faf782 into master May 20, 2020
@ToniBonittoGSA ToniBonittoGSA deleted the sc_fix-gulp-img branch May 20, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: frontend ideas and issues related to the presentation layer of the site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants