New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation report sometimes doesn't provide enough context #87

Open
gbinal opened this Issue Feb 24, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@gbinal
Member

gbinal commented Feb 24, 2014

If a report isn't generating because of missing fields, the validation report just has entries like this, which don't say what specifically is wrong.

It would be helpful if they included a mention of what field was missing to trigger the omission.

2014-02-24 15:31:58,986 - Dataset id=[edb8e0ef-3511-4292-818d-a6dfe2042534], title=[Crop Explorer] omitted
2014-02-24 15:31:58,986 - Dataset id=[04a6664e-ced9-44bb-a3c7-7eaa8739cc7a], title=[Export Sales Reporting] omitted
2014-02-24 15:31:58,987 - Dataset id=[a9f9ad80-2974-4e15-94ca-fd6a85d93912], title=[Global Agricultural Information Network] omitted
@dinali

This comment has been minimized.

Show comment
Hide comment
@dinali

dinali Feb 28, 2014

Maybe this issue has been closed? When you click the Enterprise Data Listing or Public Data Listing buttons, two files are generated. One is the errorlist.txt file which contains the verbose error description, it contains the validators best guess as to what triggered the exception, The other file datajson.txt appears to be the datasets that passed validation. A contractor sent me the succint error file similar to what you have shown in your example, but CKAN doesn't seem to generate it any longer, or maybe I'm missing something.

e.g. On instance[u'dataQuality']:
u'true'
2014-02-27 15:18:44,535 - Dataset id=[11b0f073-5dc9-439f-b73e-7a20171b2108], title=[Agricultural Exchange Rate Data Set] omitted
2014-02-27 15:18:44,540 - Validation failed, best guess of error = u'' does not match u'^[-\w]+/[-\w]+(.[-\w]+)*([+][-\w]+)?$'

Failed validating u'pattern' in schema[u'properties'][u'distribution'][u'items'][u'properties'][u'format']:
{u'description': u'The file format or API type of the distribution.',
u'pattern': u'^[-\w]+/[-\w]+(.[-\w]+)*([+][-\w]+)?$',
u'title': u'Format',
u'type': u'string'}

dinali commented Feb 28, 2014

Maybe this issue has been closed? When you click the Enterprise Data Listing or Public Data Listing buttons, two files are generated. One is the errorlist.txt file which contains the verbose error description, it contains the validators best guess as to what triggered the exception, The other file datajson.txt appears to be the datasets that passed validation. A contractor sent me the succint error file similar to what you have shown in your example, but CKAN doesn't seem to generate it any longer, or maybe I'm missing something.

e.g. On instance[u'dataQuality']:
u'true'
2014-02-27 15:18:44,535 - Dataset id=[11b0f073-5dc9-439f-b73e-7a20171b2108], title=[Agricultural Exchange Rate Data Set] omitted
2014-02-27 15:18:44,540 - Validation failed, best guess of error = u'' does not match u'^[-\w]+/[-\w]+(.[-\w]+)*([+][-\w]+)?$'

Failed validating u'pattern' in schema[u'properties'][u'distribution'][u'items'][u'properties'][u'format']:
{u'description': u'The file format or API type of the distribution.',
u'pattern': u'^[-\w]+/[-\w]+(.[-\w]+)*([+][-\w]+)?$',
u'title': u'Format',
u'type': u'string'}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment