• Pull Request (PR) Review Process
• Introduction
• Approach
• What we look for
• Untested code
• Does not contain secrets
• All logical paths are tested
• Logical AND and OR operations are tested
• Test names describe what the tests are doing
• Tests actually do what they’re supposed to
• Opportunities to abstract and refactor
• Unwieldy methods
• Meaningful method and variable names
• Commented-out code
• Necessary comments
• Documented APIs
• Adherence to the project’s style guide
• What we’ll do
• We’ll be nitpicky
• We’ll be thorough
• We’ll ask questions
• We’ll be kind
• Checklist